Create CSV file on customized path #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chia7712
reviewed
Feb 8, 2022
chia7712
reviewed
Feb 8, 2022
chia7712
reviewed
Feb 8, 2022
chia7712
reviewed
Feb 8, 2022
Change the name of `FileWriter` to `ReportWriter`. Change path type to java `Path` class. Make some method become static.
Rename argument name ("--createCSV" to "--create.report").
chia7712
reviewed
Feb 17, 2022
chia7712
reviewed
Feb 17, 2022
Change `--report.path` default value to "no report".
chia7712
reviewed
Mar 1, 2022
There was a problem hiding this comment.
@chinghongfang Sorry for bring a couple of comments again. Also, please fix the conflicts.
And reduce the code
chia7712
reviewed
Mar 4, 2022
chia7712
reviewed
Mar 4, 2022
|
@chinghongfang 不好意思，可否修正一下衝突 |
chia7712
approved these changes
Mar 31, 2022
|
@chinghongfang 理想上這些新功能要有對應的測試會比較好，可否麻煩你開一個議題追蹤一下，看之後比較空閒能否補上 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#172 (comment)
此PR讓使用者可以自行決定要把輸出的CSV檔放在哪裡。
若指定的路徑不存在，則會中止。
若指定的路徑是以
.csv結尾，則會使用該檔名，不另外製作。