-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fixes: Mac runner upgrade and Doxygen installations #3921
Conversation
…acOS 14 now that 12 is deprecated
ci changes LGTM 👍 other unrelated changes, however, snuck in, please remove if these need separate review. Feel free to merge after addressing.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to limit this to ci, unless you feel the other changes are relevant to this PR
The CI failures on Mac seems to be related to updating the runner to |
Note: could improve Doxygen install based on simbody/simbody#801. |
…e-differenced estimate
@aymanhab asking for another review here since I've made several changes. Finally patched all the testing failures, some of them were hidden because we were using non-Catch2 macros (e.g., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @nickbianco I'd just spot check Doxygen to see if the result is usable or if we need to upgrade or configuration files
Reviewed 2 of 4 files at r3, 1 of 1 files at r4.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @nickbianco)
.github/workflows/continuous_integration.yml
line 30 at r4 (raw file):
run: | (New-Object System.Net.WebClient).DownloadFile("https://github.com/doxygen/doxygen/releases/download/Release_1_12_0/doxygen-1.12.0.windows.x64.bin.zip", "doxygen.zip") 7z x $env:GITHUB_WORKSPACE/doxygen.zip -odoxygen
We were sticking with 1.8.14 on windows because later versions were problematic and produced unexpected docs. Would be good to spot check the layout/colors/etc. locally
Tried using I will take a look at the docs generated with the new version of Doxygen. |
Actually, the image I posted above is from the Mac CI builds, which already had been installing the latest version of Doxygen (1.12) via Homebrew. So the changes in this PR actually bring the Windows and Mac builds in sync on the Doxygen version. If it's okay with you @aymanhab, I think I'll open a separate issue specific issues with using the latest Doxygen. That way we can get CI up and running in the meantime. |
(And we can always build the docs locally with whatever version of Doxgyen we need for releases, etc.) |
Sure, let's merge if you're happy with everything else so we have successful builds. It may make sense to build Doxygen on windows only if unused on other platforms but that's to discuss separately on the Doxygen issue. |
Brief summary of changes
Upgrades all Mac runners to
macOS 14
now thatmacOS 12
will be officially deprecated soon (already receiving warnings in GitHub Actions). Attempts to fix the Doxygen install issue on Windows; there is a comment suggesting that achoco
install was previously unreliable, but giving it a try again here.Testing I've completed
[perf-win]
Looking for feedback on...
CHANGELOG.md (choose one)
Performance analysis
Platform: Windows, self-hosted runner
This change is