OCPBUGS-43108: [release-4.17] Delete webhooks when SriovOperatorConfig is deleted #1017
Conversation
When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error: ``` Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found ``` as the webhook configuration is still present, while the Service and the DaemonSet has been deleted. Delete all the webhook configurations when the user deletes the default SriovOperatorConfig Signed-off-by: Andrea Panattoni <[email protected]>
|
/jira cherrypick OCPBUGS-41897 |
|
@zeeke: Jira Issue OCPBUGS-41897 has been cloned as Jira Issue OCPBUGS-43108. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@zeeke: This pull request references Jira Issue OCPBUGS-43108, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/test e2e-telco5g-sriov |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@zeeke: This pull request references Jira Issue OCPBUGS-43108, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
See also 4.16 issue OCPBUGS-37951. lgtm. |
|
/lgtm |
The `DiscoverSriovDevices` routine produces a huge amount of log entries, making debugging problems hard. Remove log entries that can produce a log line for each configured VF and which does not produce any change in the environment. Signed-off-by: Andrea Panattoni <[email protected]>
|
Also added a small log optimization 4734e36 |
|
/test e2e-telco5g-sriov |
|
@zeeke: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@SchSeba @evgenLevin please take a look at this backport |
|
/lgtm |
openshift-ci
bot
added
the
cherry-pick-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evgenLevin, wizhaoredhat, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned ajaggapa, anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721 and rbbratta
openshift-merge-bot
bot
merged commit 2d364e1
into
openshift:release-4.17
|
@zeeke: Jira Issue OCPBUGS-43108: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43108 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
|
/jira backport release-4.16 |
|
@zeeke: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #1033 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error:
as the webhook configuration is still present, while the Service and the DaemonSet has been deleted.
Delete all the webhook configurations when the user deletes the default SriovOperatorConfig
4.17 backport of