Delete webhooks when SriovOperatorConfig is deleted #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
zeeke
force-pushed
the
us/OCPBUGS-41897
branch
from
245a8f0 to
32983c4
Compare
Pull Request Test Coverage Report for Build 10955652211Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
e0ne
requested changes
Sep 20, 2024
| @@ -457,3 +461,29 @@ func (r SriovOperatorConfigReconciler) setLabelInsideObject(ctx context.Context, | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (r SriovOperatorConfigReconciler) deleteAllWebhooks(ctx context.Context) error { | |||
There was a problem hiding this comment.
please, re-use deleteWebhookObject method here
When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error: ``` Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found ``` as the webhook configuration is still present, while the Service and the DaemonSet has been deleted. Delete all the webhook configurations when the user deletes the default SriovOperatorConfig Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
us/OCPBUGS-41897
branch
from
32983c4 to
644fcf2
Compare
e0ne
approved these changes
Oct 1, 2024
bn222
reviewed
Oct 11, 2024
| return reconcile.Result{}, nil | ||
|
|
||
| err := r.deleteAllWebhooks(ctx) | ||
| return reconcile.Result{}, err |
There was a problem hiding this comment.
Why don't we use owner reference? Then, all of this is automatically handled.
There was a problem hiding this comment.
Because ValidatingWebhookConfiguration and MutatingWebhookConfiguration resources are not namespaced, while the OwnerReference field works with resources in the same namespace as the owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterward, the operator webhooks returns the error:
as the webhook configuration is still present, while the Service and the DaemonSet have been deleted.
Delete all the webhook configurations when the user deletes the default SriovOperatorConfig