Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we use custom image while testing the operator #7609

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Make sure we use custom image while testing the operator #7609

merged 1 commit into from
Mar 12, 2020

Conversation

ravisantoshgudimetla
Copy link
Contributor

As part of the PR #7317, we forgot to update the prow job & config to use the custom image we're building for CI. While the CI as of now is building the container image, it's not being used in our e2e-operator job. This commit should address that problem

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2020
@ravisantoshgudimetla
Copy link
Contributor Author

/cc @sebsoto @aravindhp

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
sebsoto
sebsoto approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@sebsoto sebsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3dc054e into openshift:master Mar 12, 2020
@openshift-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-windows-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml

In response to this:

As part of the PR #7317, we forgot to update the prow job & config to use the custom image we're building for CI. While the CI as of now is building the container image, it's not being used in our e2e-operator job. This commit should address that problem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Mar 12, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/windows-machine-config-operator/master/e2e-operator be229eb link /test pj-rehearse
ci/prow/pj-rehearse be229eb link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Jul 13, 2020
Merged
ravisantoshgudimetla added a commit to ravisantoshgudimetla/release that referenced this pull request Jul 13, 2020
@ravisantoshgudimetla
[wmco] Stop excluding WMCO image while promoting
72003e6 
openshift#7609 introduced a change which caused
the WMCO image not to be published. We need the image to be published so that
it can be consumed by other repos like CNO and ovn-kubernetes. This PR should
address it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsoto sebsoto sebsoto approved these changes

@aravindhp aravindhp Awaiting requested review from aravindhp

@droslean droslean Awaiting requested review from droslean

Assignees

@sebsoto sebsoto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravisantoshgudimetla @openshift-ci-robot @sebsoto @openshift-merge-robot