CI integration for windows-machine-config-operator #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
aravindhp
force-pushed
the
wmco
branch
2 times, most recently
from
0584009 to
4a91a4d
Compare
|
/test pj-rehearse |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
|
/retest |
1 similar comment
|
/retest |
|
/test pj-rehearse |
Ran "make new-repo" with the following configuration: ``` Welcome to the repository configuration initializer. In order to generate a new set of configurations, some information will be necessary. Let's start with general information about the repository... Enter the organization for the repository: openshift Enter the repository to initialize: windows-machine-config-operator Enter the development branch for the repository: [default: master] Now, let's determine how the repository builds output artifacts... Does the repository build and promote container images? [default: no] yes Does the repository promote images as part of the OpenShift release? [default: no] Do any images build on top of the OpenShift base image? [default: no] Do any images build on top of the CentOS base image? [default: no] Now, let's configure how the repository is compiled... What version of Go does the repository build with? [default: 1.13] [OPTIONAL] Enter the Go import path for the repository if it uses a vanity URL (e.g. "k8s.io/my-repo"): [OPTIONAL] What commands are used to build binaries in the repository? (e.g. "go install ./cmd/...") make build [OPTIONAL] What commands are used to build test binaries? (e.g. "go install -race ./cmd/..." or "go test -c ./test/...") Now, let's configure test jobs for the repository... First, we will configure simple test scripts. Test scripts execute unit or integration style tests by running a command from your repository inside of a test container. For example, a unit test may be executed by running "make test-unit" after checking out the code under test. Are there any test scripts to configure? [default: no] yes What is the name of this test (e.g. "unit")? lint Does this test require built binaries? [default: no] What commands in the repository run the test (e.g. "make test-unit")? make lint Are there any more test scripts to configure? [default: no] yes What is the name of this test (e.g. "unit")? build Does this test require built binaries? [default: no] What commands in the repository run the test (e.g. "make test-unit")? make build Are there any more test scripts to configure? [default: no] Next, we will configure end-to-end tests. An end-to-end test executes a command from your repository against an ephemeral OpenShift cluster. The test script will have "cluster:admin" credentials with which it can execute no other tests will share the cluster. Are there any end-to-end test scripts to configure? [default: no] yes What is the name of this test (e.g. "e2e-operator")? e2e-operator Which specific cloud provider does the test require, if any? [default: aws] aws What commands in the repository run the test (e.g. "make test-e2e")? make run-ci-e2e-test Are there any more end-to-end test scripts to configure? [default: no] ```
Add the images config option pointing to the Dockerfile in the WMCO repo and execute, "make jobs".
- Remove the e2e-operator from the config. - Remove prow-gen-controlled:true as prow-gen does not support specifying CLUSTER_VARIANT.
Ran "make jobs" to generate the job.
|
/retest |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all The requirements for Bugzilla bugs have changed, recalculating validity. |
|
/retest |
aravindhp
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @sdodson @openshift/openshift-team-developer-productivity-test-platform |
sebsoto
reviewed
Feb 28, 2020
| @@ -101,6 +100,8 @@ presubmits: | |||
| env: | |||
| - name: CLUSTER_TYPE | |||
| value: aws | |||
| - name: CLUSTER_VARIANT | |||
There was a problem hiding this comment.
Its annoying that this needs to be done manually still
stevekuznetsov
approved these changes
Feb 28, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, sebsoto, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@aravindhp: Updated the following 7 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and execute, "make jobs".