Add v1.9-branch to the ci config

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-10796
Related to: opendatahub-io/kubeflow#385

Add v1.9-branch to opendatahub-io/kubeflow repo.

[jiridanek]

{"component":"check-gh-automation","file":"/go/src/github.com/openshift/ci-tools/cmd/check-gh-automation/main.go:218","func":"main.checkRepos","level":"error","msg":"Bot openshift-merge-robot does not have admin access in opendatahub-io/kubeflow with branch protection enabled","severity":"error","time":"2024-09-17T10:55:21Z"}

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/56800/pull-ci-openshift-release-check-gh-automation/1835995414520664064

what's this?

[atheo89]

{"component":"check-gh-automation","file":"/go/src/github.com/openshift/ci-tools/cmd/check-gh-automation/main.go:218","func":"main.checkRepos","level":"error","msg":"Bot openshift-merge-robot does not have admin access in opendatahub-io/kubeflow with branch protection enabled","severity":"error","time":"2024-09-17T10:55:21Z"}

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/56800/pull-ci-openshift-release-check-gh-automation/1835995414520664064

what's this?

Opened a PR #56853 to fix this, we should add on the _prowconfig.yaml branch-protection rules. (Based on discussion with testplatform team.) Once the #56853 get merged we should re-run the ci/prow/check-gh-automation and see if it fixed

[atheo89]

/test check-gh-automation

[atheo89]

Hello @smg247, we still deal with this failure... In this case we have merge first the protection-branch rules in _prowconfig.yml file via this PR https://github.com/openshift/release/pull/56853/files
This is the branch that we try to configure (where we don't apply any protection rule) What we are missing?

[smg247]

Apparently, check-gh-automation is not advanced enough to tell that branch protection is unmanaged for that specific branch only. You would need to set it to unmanaged at the repo level to satisfy it. I would rather see you give admin rights to the bot so that this can be done the correct way. I don't have the bandwidth to fix the check right now (and this has actually never come up before, so it isn't a common configuration to have), so I can just override the check for you if you want. To summarize your options:

1. Give openshift-merge-robot admin rights in your repo (preferred)
2. Set the entire repo's branch-protection to unmanaged: true
3. Let me know if you want me to override the check, but it will keep failing in subsequent PRs

[jiridanek]

Give openshift-merge-robot admin rights in your repo (preferred)

@atheo89 I think this is reasonable thing to do. I suggest you sync with @harshad16 and do this.

/lgtm
/pj-rehearse auto-ack

[openshift-ci-robot]

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jiridanek]

silly me, there's no 1.9 code yet, let's just ack this and see on the 1.9 pr what happens
/pj-rehearse auto-ack

[openshift-ci-robot]

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jiridanek]

/pj-rehearse ack

[openshift-ci-robot]

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jiridanek]

/override ci/prow/check-gh-automation

[openshift-ci]

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/check-gh-automation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 10b01da and 2 for PR HEAD 874d9b7 in total

[harshad16]

/test check-gh-automation

[harshad16]

We have included Admin rights to the openshift-merge-bot for the required repositories.
Thanks @smg247 and @atheo89 for working and sharing these bits.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 10b01da and 2 for PR HEAD 874d9b7 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4cacddf and 1 for PR HEAD 874d9b7 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8bc09f9 and 0 for PR HEAD 874d9b7 in total

[openshift-ci-robot]

/hold

Revision 874d9b7 was retested 3 times: holding

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@atheo89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-opendatahub-io-kubeflow-v1.9-branch-images	opendatahub-io/kubeflow	presubmit	Presubmit changed
pull-ci-opendatahub-io-kubeflow-v1.9-branch-kf-notebook-controller-pr-image-mirror	opendatahub-io/kubeflow	presubmit	Presubmit changed
pull-ci-opendatahub-io-kubeflow-v1.9-branch-kf-notebook-controller-unit	opendatahub-io/kubeflow	presubmit	Presubmit changed
pull-ci-opendatahub-io-kubeflow-v1.9-branch-odh-notebook-controller-e2e	opendatahub-io/kubeflow	presubmit	Presubmit changed
pull-ci-opendatahub-io-kubeflow-v1.9-branch-odh-notebook-controller-pr-image-mirror	opendatahub-io/kubeflow	presubmit	Presubmit changed
pull-ci-opendatahub-io-kubeflow-v1.9-branch-odh-notebook-controller-unit	opendatahub-io/kubeflow	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[atheo89]

/pj-rehearse ack

[openshift-ci-robot]

@atheo89: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[atheo89]

/unhold

[atheo89]

Thank you all so much, for your help with this! We’ve got it all sorted! 💯
I will need only a /lgtm 🙂

[jstourac]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/opendatahub-io/kubeflow/OWNERS [atheo89,jiridanek,jstourac]
• ci-operator/jobs/opendatahub-io/kubeflow/OWNERS [atheo89,jiridanek,jstourac]
• core-services/prow/02_config/opendatahub-io/kubeflow/OWNERS [atheo89,jiridanek,jstourac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@atheo89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@atheo89: Updated the config configmap in namespace ci at cluster app.ci using the following files:

• key core-services-prow-02_config-opendatahub-io-kubeflow-_prowconfig.yaml using file core-services/prow/02_config/opendatahub-io/kubeflow/_prowconfig.yaml

In response to this:

Related to: https://issues.redhat.com/browse/RHOAIENG-10796
Related to: opendatahub-io/kubeflow#385

Add v1.9-branch to opendatahub-io/kubeflow repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.