Upgrade notebook-controller with upstream 1.9.0 Release #385

atheo89 · 2024-09-13T09:53:03Z

Related to: https://issues.redhat.com/browse/RHOAIENG-10796
CI-config PR: openshift/release#56800

Old sync testing PR: #383

Description

Upgrade notebook-controller with upstream 1.9.0 Release

Checkout upstream/v1.9-branch from upstream/v1.7-branch
git remote add kfbf-upstream https://github.com/kubeflow/kubeflow.git
git fetch --all && git pull --all
git remote -v

    kfbf-upstream   https://github.com/kubeflow/kubeflow.git (fetch)
    kfbf-upstream   https://github.com/kubeflow/kubeflow.git (push)
    origin  https://github.com/atheo89/kubeflow.git (fetch)
    origin  https://github.com/atheo89/kubeflow.git (push)
    upstream        https://github.com/opendatahub-io/kubeflow.git (fetch)
    upstream        https://github.com/opendatahub-io/kubeflow.git (push)

git checkout -b [RHOAIENG-10796](https://issues.redhat.com//browse/RHOAIENG-10796) upstream/1.9-branch
git pull kfbf-upstream v1.9-branch --no-rebase
Resolve conflicts
git add . && git commit
git push origin [RHOAIENG-10796](https://issues.redhat.com//browse/RHOAIENG-10796)

How Has This Been Tested?

Replace the odh and notebook controllers deployments with the following images:
- Notebook-controller Image: quay.io/rh_ee_atheodor/notebook-controller:v1.9
- ODH Notebook-controller Image: quay.io/rh_ee_atheodor/odh-notebook-controller:v1.9
Try to spin up a new notebook and ensure that everything is working fine
Inspect the logs for both controllers and ensure no error logs are there

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

…ding notebook (kubeflow#6899) * vwa(back): Append notebooks using each PVC Append notebooks using each PVC when getting and parsing all PVCs. Refs arrikto/dev#2017 Signed-off-by: Orfeas Kourkakis <[email protected]> Reviewed-by: Kimonas Sotirchos <[email protected]> * vwa(front): Create custom delete action column Create custom delete column component that extends ActionComponent from Kubeflow common code and adds the following functionalities: * Disable the button when a row's notebooks array is not empty * Display an appropriate message including the notebooks' names Refs arrikto/dev#2017 Signed-off-by: Orfeas Kourkakis <[email protected]> Reviewed-by: Kimonas Sotirchos <[email protected]> * vwa(front): Add delete button component in index page Implement custom delete column in the table in VWA's index page. Refs arrikto/dev#2017 Signed-off-by: Orfeas Kourkakis <[email protected]> Reviewed-by: Kimonas Sotirchos <[email protected]> * vwa(front): Add Used by column in volumes table Add a Used by column in volumes table of VWA's index page in order to link to the notebooks that are using each PVC. Refs arrikto/dev#2017 Signed-off-by: Orfeas Kourkakis <[email protected]> Reviewed-by: Kimonas Sotirchos <[email protected]> * vwa(front): Fix integration tests Update mock request for PVCs Refs arrikto/dev#2017 Refs arrikto/dev#2135 Signed-off-by: Orfeas Kourkakis <[email protected]> Reviewed-by: Kimonas Sotirchos <[email protected]> * vwa(front): Fix format error Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Fix linting errors Signed-off-by: Orfeas Kourkakis <[email protected]> --------- Signed-off-by: Orfeas Kourkakis <[email protected]>

* centraldashboard(front): Install Cypress - Install Cypress & npm scripts for UI tests - Update frontend README.md with UI tests instructions Signed-off-by: Orfeas Kourkakis <[email protected]> * centraldashboard-angular(front): Add UI tests with Cypress Add UI tests with Cypress to check that the URLs of the browser and the iframe are always synced. More specifically, we test the following scenarios: - User navigates to pages inside the same WA (JWA) - User navigates to another WA from the one they were previously in (to the corresponding PVC from JWA details page) - User clicks and affects the query parameters of the current URL (navigates to tabs inside JWA details page) Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb-angular(front): Modify script names Modify script names in order to conform with script names in other WAs. Signed-off-by: Orfeas Kourkakis <[email protected]> * gh-actions(cdb-angular): Add UI tests to CDB's frontend workflow Signed-off-by: Orfeas Kourkakis <[email protected]> --------- Signed-off-by: Orfeas Kourkakis <[email protected]>

kubeflow#6923)

…rvice` (kubeflow#6609) * Pin alpine repository version * Introduce a new LogoutButton component

* cdb-angular: Modify README.md port-forward instructions Add instructions to port-forward Profiles KFAM service. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Modify SnackBar service to use config parameter Modify SnackBarService to: - Accept as a parameter a config object that will be able to include all possible configurations MatSnackBarService - Inject MAT_SNACK_BAR_DEFAULT_OPTIONS. This allows a structured way for every WA to provide to the service a default configuration app-wide for values like like HorizontalPosition and duration. Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb(front): Use Kubeflow common library Build CDB using components from Kubeflow's common libary. Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb-angular(front): Introduce backend service and ErrorInterceptor - Introduce backend service to handle requests to the backend - Use snackBar service by KF common library - Introduce ErrorInterceptor to hanlde errors in a uniform way. Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb-angular(back): Remove "kubeflowVersion" from API Remove the "kubeflowVersion from Workgroup's API "/env-info" endpoint since it was using CRDs which are deprecated. Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb-angular(back): Modify KF build version during runtime By default, the version displayed in the dashboard's sidebar is the ENV variable `BUILD_VERSION` defined during build time. With this change, the `/api/workgroup/env-info` endpoint may now return the build's label, version, and id which will be displayed instead of the BUILD_VERSION. These values are assigned during runtime and can be defined through the deployment's `KF_DASHBOARD_BUILD_LABEL`, `KF_DASHBOARD_VERSION` and `KF_DASHBOARD_BUILD_ID` ENV variables. Signed-off-by: Orfeas Kourkakis <[email protected]> * cdb-angular(front): Show KF version in the left sidebar Show KF version at the bottom of the left sidebar navigation menu. Variables that are used to show the KF version get their default values during build time but may be modified during runtime by the depoloyment's ENV vars fetched from the request at '/api/workflow/env-info'. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Update the use of SnackBarService Update the use of SnackBarService in order to pass required data via a `config` object. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Update the use of SnackBarService Update the use of SnackBarService in order to pass required data via a `config` object. Signed-off-by: Orfeas Kourkakis <[email protected]> * twa(front): Update the use of SnackBarService Update the use of SnackBarService in order to pass required data via a `config` object. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Fix flaky filtering unit test Signed-off-by: Orfeas Kourkakis <[email protected]> --------- Signed-off-by: Orfeas Kourkakis <[email protected]>

* support Pod Defaults in Tensorboard Web App * flint files

* Add approvers to the frontends Signed-off-by: Kimonas Sotirchos <[email protected]> * Add owners to common frontend code Signed-off-by: Kimonas Sotirchos <[email protected]> --------- Signed-off-by: Kimonas Sotirchos <[email protected]>

…omponents/centraldashboard-angular/frontend (kubeflow#6951) Removes [cacheable-request](https://github.com/jaredwray/cacheable-request). It's no longer used after updating ancestor dependency [@kubernetes/client-node](https://github.com/kubernetes-client/javascript). These dependencies need to be updated together. Removes `cacheable-request` Updates `@kubernetes/client-node` from 0.16.3 to 0.18.1 - [Release notes](https://github.com/kubernetes-client/javascript/releases) - [Changelog](https://github.com/kubernetes-client/javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes-client/javascript/commits) --- updated-dependencies: - dependency-name: cacheable-request dependency-type: indirect - dependency-name: "@kubernetes/client-node" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Update the cert-manager installation script to use the pre-built yaml file from Cert Manager releases. This is to avoid rebuilding the manifests as part of Kubeflow and having to use other CLIs. Signed-off-by: Kimonas Sotirchos <[email protected]>

…pps/tensorboards/frontend (kubeflow#6877) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…pps/common/frontend/kubeflow-common-lib (kubeflow#6878) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix Activities list test that was failing because new Date () added whitespace that was not equal to the space character during comparison. Signed-off-by: Orfeas Kourkakis <[email protected]>

Previously the app would not use the correct directory when running the docker buildx command, which resulted in the image to fail to get built. Signed-off-by: Kimonas Sotirchos <[email protected]>

* centraldashboard: Don't run tests in docker build Run the frontend tests outside of the Dockerfile and inside a dedicated GH Action. We should separate the testing process from the building one. The dashboard's Dockerfile was running the tests because in the early days, when Kubeflow didn't have a CI, this was the only reproducible way to ensure the tests had passed when creating an image. Signed-off-by: Kimonas Sotirchos <[email protected]> * gh-actions: Build multi-arch image for centraldashboard on PRs Update the GH Action that we run when a PR is opened to use the multi-arch build rule, to ensure we run the same script once a PR is merged. Signed-off-by: Kimonas Sotirchos <[email protected]> * gh-action: Set multi arch ENV Var Signed-off-by: Kimonas Sotirchos <[email protected]> * centraldashboard(make): Use --load on multi-arch build Without this flag the result image will only remain in the build cache. Signed-off-by: Kimonas Sotirchos <[email protected]> * wip: Try building/loading each image explicitly Signed-off-by: Kimonas Sotirchos <[email protected]> --------- Signed-off-by: Kimonas Sotirchos <[email protected]>

Use dynamic URL for the logout button that can be set by the LOGOUT_URL ENV variable in the deployment of the app. If it is unset, a default '/logout' string is passed from the backend to the frontend. Signed-off-by: Orfeas Kourkakis <[email protected]>

…pps/volumes/frontend (kubeflow#6881) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…pps/jupyter/frontend (kubeflow#6880) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…hboard-angular/frontend (kubeflow#6883) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…entraldashboard-angular/frontend (kubeflow#6905) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…entraldashboard (kubeflow#6906) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…rud-web-apps/tensorboards/frontend (kubeflow#6907) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…rud-web-apps/volumes/frontend (kubeflow#6908) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1.11.1 in /components/notebook-controller (kubeflow#6955) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1.11.1 in /components/tensorboard-controller (kubeflow#6956) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

….11.1 in /components/access-management (kubeflow#6957) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 0.9.2 to 1.11.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v0.9.2...v1.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix the action component to properly show the tooltip of the start-stop action button in JWA. Signed-off-by: Elena Zioga <[email protected]>

* Document the release process for Notebooks Signed-off-by: Anna Jung (VMware) <[email protected]> * Add hanbook reference based on feedback Signed-off-by: Anna Jung (VMware) <[email protected]> --------- Signed-off-by: Anna Jung (VMware) <[email protected]>

…tebook from snapshot (kubeflow#6897) * web-apps(front): Introduce MemoryValue class Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Introduce unit tests for the MemoryValue class Signed-off-by: Elena Zioga <[email protected]> * jwa(front): Use MemoryValue class for memory column Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Make quantityToScalar() use only Number() Signed-off-by: Elena Zioga <[email protected]> * jwa(front): Update quantityToScalar() import Signed-off-by: Elena Zioga <[email protected]> * vwa(front): Update quantityToScalar() import Signed-off-by: Elena Zioga <[email protected]> --------- Signed-off-by: Elena Zioga <[email protected]>

.github/OWNERS

atheo89 · 2024-09-17T10:56:38Z

Thank you for your review 🙂

This is the CI configuration for the new branch -> openshift/release#56800

I am working on the rest (midstream repo & nightlies) @jiridanek

jiridanek · 2024-09-17T14:10:27Z

There's a bit less CI than what we have in 1.7, wouldn't you say? Compare with #381 (comment) which also did some builds

harshad16

Thanks for the awesome work.

Apart from OWNERs file upgrade
need one more change

components/notebook-controller/config/manager/manager.yaml

atheo89 · 2024-09-18T08:22:20Z

There's a bit less CI than what we have in 1.7, wouldn't you say? Compare with #381 (comment) which also did some builds

Hmm we didn't touch the CIs tests, we have exactly the same. Current development branch, v1.9-branch vs v1.7-branch

harshad16 · 2024-09-18T12:53:05Z

There's a bit less CI than what we have in 1.7, wouldn't you say? Compare with #381 (comment) which also did some builds

Hmm we didn't touch the CIs tests, we have exactly the same. Current development branch, v1.9-branch vs v1.7-branch

I believe the confusion is why didn't these workflow run:

kubeflow/.github/workflows/notebook_controller_integration_test.yaml

Line 6 in a99e2d7

- components/notebook-controller/**

though it seems there is no problem, perhaps a flake from github side.

harshad16 · 2024-09-18T12:54:20Z

@atheo89 , seems like the OWNER files verification from openshift-ci (prow) would keep showing up.
would you please remove all the OWNERs files as an additional commit in the PR.
so we are ready to evaluate this PR.

atheo89 · 2024-09-18T13:29:39Z

@atheo89 , seems like the OWNER files verification from openshift-ci (prow) would keep showing up.
would you please remove all the OWNERs files as an additional commit in the PR.
so we are ready to evaluate this PR.

@harshad16 , I removed all the sub-owners on this commit

harshad16

/lgtm
/approve

thank you for the excellent work.
Created separate task for fixing the golang lint:
RHOAIENG-13098
so we can move forward with this and start building and testing this work.

openshift-ci · 2024-09-18T14:52:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [harshad16,jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jstourac · 2024-09-18T15:35:56Z

thank you for the excellent work. Created separate task for fixing the golang lint: RHOAIENG-13098 so we can move forward with this and start building and testing this work.

As Jiri mentioned here already, there is an issue related for the golint fixes 🙂

jiridanek · 2024-09-19T11:38:35Z

/override "Code static analysis/golangci-lint (components/notebook-controller)"
/override "Code static analysis/golangci-lint (components/odh-notebook-controller)"

openshift-ci · 2024-09-19T11:38:46Z

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Code static analysis/golangci-lint (components/notebook-controller)
Code static analysis/golangci-lint (components/odh-notebook-controller)

Only the following failed contexts/checkruns were expected:

ci/prow/images
ci/prow/kf-notebook-controller-pr-image-mirror
ci/prow/kf-notebook-controller-unit
ci/prow/odh-notebook-controller-e2e
ci/prow/odh-notebook-controller-pr-image-mirror
ci/prow/odh-notebook-controller-unit
golangci-lint (components/notebook-controller)
golangci-lint (components/odh-notebook-controller)
pull-ci-opendatahub-io-kubeflow-master-images
pull-ci-opendatahub-io-kubeflow-master-kf-notebook-controller-pr-image-mirror
pull-ci-opendatahub-io-kubeflow-master-kf-notebook-controller-unit
pull-ci-opendatahub-io-kubeflow-master-odh-notebook-controller-e2e
pull-ci-opendatahub-io-kubeflow-master-odh-notebook-controller-pr-image-mirror
pull-ci-opendatahub-io-kubeflow-master-odh-notebook-controller-unit
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code static analysis/golangci-lint (components/notebook-controller)"
/override "Code static analysis/golangci-lint (components/odh-notebook-controller)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2024-09-19T11:39:14Z

/override "golangci-lint (components/notebook-controller)"
/override "golangci-lint (components/odh-notebook-controller)"

openshift-ci · 2024-09-19T11:39:26Z

@jiridanek: Overrode contexts on behalf of jiridanek: golangci-lint (components/notebook-controller), golangci-lint (components/odh-notebook-controller)

In response to this:

/override "golangci-lint (components/notebook-controller)"
/override "golangci-lint (components/odh-notebook-controller)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

harshad16 · 2024-09-19T14:10:49Z

thank you for the excellent work. Created separate task for fixing the golang lint: RHOAIENG-13098 so we can move forward with this and start building and testing this work.

As Jiri mentioned here already, there is an issue related for the golint fixes 🙂

@jstourac thanks for pointing me to it
i will close the issue i created as duplicate of the other.

orfeas-k and others added 30 commits January 30, 2023 10:02

Adding support for linux/ppc64le in CI for centraldashboard multi-arc… (

65e41bf

kubeflow#6923)

Fix the logout button to work with the recent version of `oidc-authse…

74f020e

…rvice` (kubeflow#6609) * Pin alpine repository version * Introduce a new LogoutButton component

Fix the bug of ResourceQuota removal (kubeflow#6188)

1552c90

Support Pod Defaults in Tensorboard Web App (kubeflow#6924)

df3d81c

* support Pod Defaults in Tensorboard Web App * flint files

Add approvers to the frontends (kubeflow#6929)

79e47ff

* Add approvers to the frontends Signed-off-by: Kimonas Sotirchos <[email protected]> * Add owners to common frontend code Signed-off-by: Kimonas Sotirchos <[email protected]> --------- Signed-off-by: Kimonas Sotirchos <[email protected]>

centraldashboard: Fix failing test (kubeflow#6959)

28a24ff

Fix Activities list test that was failing because new Date () added whitespace that was not equal to the space character during comparison. Signed-off-by: Orfeas Kourkakis <[email protected]>

centraldashboard(make): Use correct dir (kubeflow#6960)

1036595

Previously the app would not use the correct directory when running the docker buildx command, which resulted in the image to fail to get built. Signed-off-by: Kimonas Sotirchos <[email protected]>

GH Action for Admission webhook unit tests (kubeflow#6893)

742566c

web-apps(front): Fix the action component (kubeflow#6967)

750cd9d

* Fix the action component to properly show the tooltip of the start-stop action button in JWA. Signed-off-by: Elena Zioga <[email protected]>

jiridanek approved these changes Sep 17, 2024

View reviewed changes

openshift-ci bot added the approved label Sep 17, 2024

jiridanek removed the approved label Sep 17, 2024

jstourac reviewed Sep 17, 2024

View reviewed changes

.github/OWNERS Outdated Show resolved Hide resolved

atheo89 mentioned this pull request Sep 17, 2024

Add v1.9-branch to the ci config openshift/release#56800

Merged

harshad16 requested changes Sep 17, 2024

View reviewed changes

components/notebook-controller/config/manager/manager.yaml Outdated Show resolved Hide resolved

openshift-ci bot assigned harshad16 Sep 17, 2024

openshift-ci bot added approved and removed lgtm labels Sep 17, 2024

removing the cluster-domain env var from the deployment

a530d15

atheo89 force-pushed the RHOAIENG-10796 branch from 358baa7 to c5de943 Compare September 18, 2024 13:26

Remove sub-owners files

081ad50

atheo89 force-pushed the RHOAIENG-10796 branch from c5de943 to 081ad50 Compare September 18, 2024 13:28

openshift-ci bot removed the do-not-merge/invalid-owners-file Do not merge this PR label Sep 18, 2024

harshad16 approved these changes Sep 18, 2024

View reviewed changes

openshift-ci bot added the lgtm label Sep 18, 2024

openshift-merge-bot bot merged commit ddd1741 into opendatahub-io:v1.9-branch Sep 19, 2024
11 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade notebook-controller with upstream 1.9.0 Release #385

Upgrade notebook-controller with upstream 1.9.0 Release #385

atheo89 commented Sep 13, 2024 •

edited

Loading

atheo89 commented Sep 17, 2024 •

edited

Loading

jiridanek commented Sep 17, 2024

harshad16 left a comment

atheo89 commented Sep 18, 2024

harshad16 commented Sep 18, 2024

harshad16 commented Sep 18, 2024

atheo89 commented Sep 18, 2024 •

edited

Loading

harshad16 left a comment

openshift-ci bot commented Sep 18, 2024

jstourac commented Sep 18, 2024

jiridanek commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

jiridanek commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

harshad16 commented Sep 19, 2024

Upgrade notebook-controller with upstream 1.9.0 Release #385

Upgrade notebook-controller with upstream 1.9.0 Release #385

Conversation

atheo89 commented Sep 13, 2024 • edited Loading

Description

How Has This Been Tested?

Merge criteria:

atheo89 commented Sep 17, 2024 • edited Loading

jiridanek commented Sep 17, 2024

harshad16 left a comment

Choose a reason for hiding this comment

atheo89 commented Sep 18, 2024

harshad16 commented Sep 18, 2024

harshad16 commented Sep 18, 2024

atheo89 commented Sep 18, 2024 • edited Loading

harshad16 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 18, 2024

jstourac commented Sep 18, 2024

jiridanek commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

jiridanek commented Sep 19, 2024

openshift-ci bot commented Sep 19, 2024

harshad16 commented Sep 19, 2024

atheo89 commented Sep 13, 2024 •

edited

Loading

atheo89 commented Sep 17, 2024 •

edited

Loading

atheo89 commented Sep 18, 2024 •

edited

Loading