Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine-config-operator: Add e2e-aws-op job #2577

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

cgwalters
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2019
@cgwalters
Copy link
Member Author

/hold

Until the dependent PR merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2019
@cgwalters
Copy link
Member Author

Rebased 🏄‍♂️ but depends on openshift/machine-config-operator#309

@cgwalters cgwalters changed the title machine-config-operator: Add e2e-aws-op job WIP: machine-config-operator: Add e2e-aws-op job Jan 16, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2019
Note I called this `-op` and not `-operator` as otherwise
prowgen warned me about too long of a job name.

See:
openshift/machine-config-operator#298
openshift/machine-config-operator#257
@cgwalters cgwalters changed the title WIP: machine-config-operator: Add e2e-aws-op job machine-config-operator: Add e2e-aws-op job Jan 16, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2019
@cgwalters
Copy link
Member Author

/hold cancel

Dependent PR merged, let's give this a try!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@ashcrow
Copy link
Member

ashcrow commented Jan 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@cgwalters
Copy link
Member Author

Looks like fallout from the Prow upgrade which was reverted.

/test config

@openshift-merge-robot openshift-merge-robot merged commit 2de323a into openshift:master Jan 16, 2019
@openshift-ci-robot
Copy link
Contributor

@cgwalters: Updated the following 3 configmaps:

  • ci-operator-configs configmap using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • job-config configmap using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml

In response to this:

See:
openshift/machine-config-operator#298
openshift/machine-config-operator#257

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants