Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test breaking e2e #317

Closed
wants to merge 2 commits into from
Closed

Conversation

cgwalters
Copy link
Member

⚠️ Don't merge ⚠️

Let's test the new test e2e-aws-op suite that should appear since openshift/release#2577

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@ashcrow
Copy link
Member

ashcrow commented Jan 16, 2019

Looks like the test was a success:

=== RUN   TestOperatorLabel
--- FAIL: TestOperatorLabel (0.10s)
	sanity_test.go:26: Expected node selector 'linux', not ''

@cgwalters
Copy link
Member Author

Yep, cool! So now we should feel confident in extending our test suite as we make further changes.

/close

@openshift-ci-robot
Copy link
Contributor

@cgwalters: Closed this PR.

In response to this:

Yep, cool! So now we should feel confident in extending our test suite as we make further changes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

(One interesting aspect of this is that our e2e-aws-op is basically testing an installer run; if it succeeds but e2e-aws fails it's more likely a flake somewhere in the origin e2e suite, not installation/cluster bringup)

@openshift-ci-robot
Copy link
Contributor

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-op d1655aa link /test e2e-aws-op
ci/prow/e2e-aws d1655aa link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
Bug 1872080: Sync RHEL/CentOS/UBI 8 imagestreams changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants