Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable service-ca-operator jobs #1569

Merged
merged 2 commits into from
Sep 24, 2018

Conversation

mrogers950
Copy link
Contributor

This PR adds builds and CI for service-ca-operator. It will eventually replace the service-serving-cert-signer entries, but we can't remove them yet.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2018
@mrogers950
Copy link
Contributor Author

@droslean @stevekuznetsov PTAL

@stevekuznetsov
Copy link
Contributor

@mrogers950 can you re-run the generator? Sorry, we changed some things while this PR was in flight

@mrogers950
Copy link
Contributor Author

@stevekuznetsov I rebased and ran prowgen on it again, but there was no change. unexpected?

@stevekuznetsov
Copy link
Contributor

Did you pull the new generator image? We updated it.

@mrogers950
Copy link
Contributor Author

@stevekuznetsov done

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrogers950, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@openshift-merge-robot openshift-merge-robot merged commit b38f9dc into openshift:master Sep 24, 2018
@openshift-ci-robot
Copy link
Contributor

@mrogers950: Updated the following 3 configmaps:

  • job-config configmap using the following files:
    • key openshift-service-ca-operator-postsubmits.yaml using file ci-operator/jobs/openshift/service-ca-operator/openshift-service-ca-operator-postsubmits.yaml
    • key openshift-service-ca-operator-presubmits.yaml using file ci-operator/jobs/openshift/service-ca-operator/openshift-service-ca-operator-presubmits.yaml
  • config configmap using the following files:
    • key config.yaml using file cluster/ci/config/prow/config.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

This PR adds builds and CI for service-ca-operator. It will eventually replace the service-serving-cert-signer entries, but we can't remove them yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins added a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Allowing extra container assest to be added in a IPv6/dissconnected deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants