add openshift-service-ca-operator

[juanvallejo]

cc @deads2k @mrogers950 @abhinavdahiya

Adds the openshift-service-ca-operator to the installer

[mrogers950]

@juanvallejo thanks! it looks OK to me but we'll need the image available for it to work. So this should wait on openshift/release#1569 (and after that @smarterclayton adding it to the mirrors)

[mrogers950]

@juanvallejo per @deads2k this should refer to the service-serving-cert-signer images for now. (and also use the operator install manifest from https://github.com/openshift/service-serving-cert-signer/blob/master/install/serving-cert-signer/install.yaml )

[mrogers950]

@juanvallejo I've opened openshift/service-serving-cert-signer#27 to update the manifests for this repo.

[deads2k]

this stands out as weird looking.

[mrogers950]

If the variable name here does not need to match the url then it could be shortened to openshift_service_ca_operator, and we can just update the url to point to origin-service-ca when we are ready to do that.

[juanvallejo]

Renamed to "openshift_service_ca_operator" and "openshift_service_ca_operator_image"

[mrogers950]

/lgtm

[juanvallejo]

/test e2e-aws

[juanvallejo]

aws e2e test failure appears to be a flake:

aws_eip.nat_eip.3: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: 79b9e5cf-97a8-4e40-8788-2fd14b885b07

[mrogers950]

/lgtm

[juanvallejo]

/retest

[mrogers950]

@juanvallejo testing the installer with this PR does not result in a running service-serving-cert-signer operator, so there is still something missing.

[mrogers950]

@juanvallejo confirmed, we have operator:

$ oc get all --all-namespaces | grep service
openshift-core-operators            pod/openshift-service-cert-signer-operator-9d49dc8cb-zvhhx   1/1       Running   0          24m
openshift-service-cert-signer       pod/apiservice-cabundle-injector-59f7f9b867-7cwnw            1/1       Running   0          19m
openshift-service-cert-signer       pod/service-serving-cert-signer-7d49c9ddbf-gclkm             1/1       Running   0          19m

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo, mrogers950
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaronlevy

If they are not already assigned, you can assign the PR to them by writing /assign @aaronlevy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mrogers950]

@abhinavdahiya this PR is ready to go. Can it be merged or is there anything blocking it?

[abhinavdahiya]

PR #330 adds installing operators using update payload. So the operator will be installed. If we can't get that merged soon: you will have to integrate with new templating code. This terrafirm module is getting deprecated. cc @crawford

[openshift-bot]

@juanvallejo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhinavdahiya]

CVO installs openshift-service-ca-operator

/close

[openshift-ci-robot]

@abhinavdahiya: Closing this PR.

In response to this:

CVO installs openshift-service-ca-operator

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.