OSD-6646: Only do health checks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 9, 2021
…operator - With openshift/configure-alertmanager-operator#143, configure-alertmanager-operator is responsible for deploying osd-cluster-ready, so that Job manifest is removed. - openshift/osd-cluster-ready#7 removes the logic that talks to prometheus and alertmanager, so `pods/exec` permissions are removed. OSD-6646
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 9, 2021
…operator - With openshift/configure-alertmanager-operator#143, configure-alertmanager-operator is responsible for deploying osd-cluster-ready, so that Job manifest is removed. - openshift/osd-cluster-ready#7 removes the logic that talks to prometheus and alertmanager, so `pods/exec` permissions are removed. - It's weird that this RBAC should still live here in MCC. Add a README acknowledging/explaining that. OSD-6646
This commit removes all "max cluster age" and silencing logic, which will [henceforth be done in configure-alertmanager-operator](openshift/configure-alertmanager-operator#147). OSD-6646
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 17, 2021
openshift/osd-cluster-ready#7 removes the logic that talks to prometheus and alertmanager, so `pods/exec` permissions are no longer needed. OSD-6646
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 18, 2021
Bump the osd-cluster-ready level to incorporate openshift/osd-cluster-ready#7. That commit removes the logic that talks to prometheus and alertmanager, so `pods/exec` permissions are no longer needed. OSD-6646
jharrington22
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
/lgtm
/hold
Hold for @iamkirkbater to review, should only be merged if openshift/configure-alertmanager-operator#147 merges.
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jharrington22
approved these changes
Mar 18, 2021
|
This is pushed to quay as |
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 19, 2021
This was missed in openshift#760 when we bumped osd-cluster-ready to include openshift/osd-cluster-ready#7, which removed max cluster age logic. OSD-6646
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 19, 2021
This was missed in openshift#760 when we bumped osd-cluster-ready to include openshift/osd-cluster-ready#7, which removed max cluster age logic. OSD-6646
2uasimojo
added a commit
to 2uasimojo/osd-cluster-ready
that referenced
this pull request
Mar 22, 2021
README: These updates were missed in openshift#7 when we changed directions away from managing the Job via configure-alertmanager-operator. deploy.sh: This was missed in openshift#7 when we removed all the other references to `MAX_CLUSTER_AGE_MINUTES`. OSD-6646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all "max cluster age" and silencing logic, which will henceforth be done in configure-alertmanager-operator.
OSD-6646