OSD-6646: Wait for ready job before configuring PD #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit coordinates with the osd-cluster-ready Job to avoid throwing alerts while the cluster is provisioning. We configure DMS, but wait to configure PagerDuty until that Job has completed (success or failure). We wait a maximum of two hours (configurable via the `MAX_CLUSTER_AGE_MINUTES` env var) for the Job to complete, at which point we configure PagerDuty anyway. OSD-6646
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 64.54% 55.12% -9.42%
==========================================
Files 8 9 +1
Lines 471 566 +95
==========================================
+ Hits 304 312 +8
- Misses 153 240 +87
Partials 14 14
|
2uasimojo
added a commit
to 2uasimojo/osd-cluster-ready
that referenced
this pull request
Mar 17, 2021
This commit removes all "max cluster age" and silencing logic, which will [henceforth be done in configure-alertmanager-operator](openshift/configure-alertmanager-operator#147). OSD-6646
|
/lgtm Major difference here with what we are currently doing in osd-cluster-ready is that we're now querying prom using Go libs which is great and looks ok to me. @2uasimojo testing in stage shows this is ok? Have you been able to test the |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, jewzaam, jharrington22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Yes and yes. All the code paths are 👍 |
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 18, 2021
Since openshift/configure-alertmanager-operator#147, configure-alertmanager-operator needs to bind to the `cluster-monitoring-view` ClusterRole in order to talk to prometheus. However, due to OLM limitations, that ClusterRoleBinding can't be deployed with c-am-o's CSV. Therefore we deploy it from here. OSD-6646
2uasimojo
added a commit
to 2uasimojo/managed-cluster-config
that referenced
this pull request
Mar 18, 2021
Since openshift/configure-alertmanager-operator#147, configure-alertmanager-operator needs to bind to the `cluster-monitoring-view` ClusterRole in order to talk to prometheus. However, due to OLM limitations, that ClusterRoleBinding can't be deployed with c-am-o's CSV. Therefore we deploy it from here. OSD-6646
2uasimojo
added a commit
to 2uasimojo/configure-alertmanager-operator
that referenced
this pull request
Mar 18, 2021
Since openshift#147, c-am-o needs to bind to the cluster-monitoring-view ClusterRole in order to be able to talk to prometheus. However, due to OLM limitations, we can't ship ClusterRoleBindings within the CSV or bundle. So instead ship it along with the OLMisms. OSD-6646
2uasimojo
added a commit
to 2uasimojo/configure-alertmanager-operator
that referenced
this pull request
Mar 18, 2021
Since openshift#147, c-am-o needs to bind to the cluster-monitoring-view ClusterRole in order to be able to talk to prometheus. However, due to OLM limitations, we can't ship ClusterRoleBindings within the CSV or bundle. So instead ship it along with the OLMisms. OSD-6646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit coordinates with the osd-cluster-ready Job to avoid throwing alerts while the cluster is provisioning. We configure DMS, but wait to configure PagerDuty until that Job has completed (success or failure). We wait a maximum of two hours (configurable via the
MAX_CLUSTER_AGE_MINUTESenv var) for the Job to complete, at which point we configure PagerDuty anyway.OSD-6646