Clarify router cmd ignoreError comments

[mrogers950]

fixes #15822
@enj @pweil-

[pweil-]

/lgtm

[enj]

/lgtm
/test extended_conformance_gce

Test flakes on OOM

[enj]

@mrogers950 you will need add the case back:

error: clusterrolebindings "router-router-role" already exists

Comment each case with a version identifier.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mrogers950]

@mrogers950 you will need add the case back:

error: clusterrolebindings "router-router-role" already exists

Comment each case with a version identifier.

I'll add it back, but I'd like to know why running 'hack/test-cmd.sh router' locally doesn't show the same failure.

[enj]

@mrogers950 the error is based on the code (not) being re-entrant. Thus it is likely the CI runs code at some earlier point that sets up the router. Running the code to set up the router a second time is not supposed to fail on the bindings already existing from the first invocation.

[enj]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950, pweil-

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/oc/OWNERS [pweil-]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[mrogers950]

@mrogers950 the error is based on the code (not) being re-entrant. Thus it is likely the CI runs code at >some earlier point that sets up the router. Running the code to set up the router a second time is not >supposed to fail on the bindings already existing from the first invocation.

@enj then that sounds like this is being exercised by a CI side-effect and we should have a test in test/cmd/router.sh that deletes and re-creates the route

[enj]

then that sounds like this is being exercised by a CI side-effect and we should have a test in test/cmd/router.sh that deletes and re-creates the route

@mrogers950 excellent idea. Please add one (either as part of this PR or a separate one).

[mrogers950]

@mrogers950 excellent idea. Please add one (either as part of this PR or a separate one).

@enj I opened #15940

[enj]

/retest

Flaked on #14575

[openshift-ci-robot]

@mrogers950: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_gce	8071064	link	/test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 15870, 15888, 15788, 15907, 15936)