RBAC Migration Followup #10: Fix router ignore error

[enj]

Fix ignoreError in pkg/oc/admin/router/router.go

[mrogers950]

@enj it looks like you're referring to correcting the 'Temp fix for test/cmd/router.sh' part of 806d7be. What are we looking for in a permanent fix here?

[mrogers950]

Removing the added check for details.Kind == "clusterrolebindings" does not cause test/cmd/router.sh to fail in any obvious way, so perhaps this fix is not needed anymore.

[enj]

@mrogers950 yeah I was hoping that reverting back the original code

return (details.Kind == "serviceaccounts" && details.Name == saName) ||
(details.Kind == "clusterrolebinding" && details.Name == roleBindingName)

would work since I had done a lot of work to make the proxy give the "correct" error.

I am fine with that as a fix, but see if you can figure out what ignoring that error actually means and add some docs around it in the code.

[mrogers950]

The ignoreError functionality was added for https://bugzilla.redhat.com/show_bug.cgi?id=1332432 via #11639. I'll clarify the comments and also revert the original code.