Bug 1763700: kubelet: add dependency on network-online.target

[rphillips]

- What I did
This fixes a race when the kubelet enumerates the hostname at startup. Wait for the network-online.target to be ready before starting the Kubelet.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1763700

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1763700, which is invalid:

• expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1763700: kubelet: add dependency on network-online.target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/bugzilla refresh

[cgwalters]

Also remember the installer has a copy of kubelet.service that needs updating too. See e.g. openshift/installer#2459

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1763700, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

Also xref:

• lazily load hostIP cri-o/cri-o#2478
• Allow default route to not be present cri-o/cri-o#2662
• https://bugzilla.redhat.com/show_bug.cgi?id=1713478

[cgwalters]

Given Kube dependency on the hostname (something that'd be good to fix eventually but)...this makes sense. Did this really never come up before though? Do other people's kubelet.service units do this too?

[ashcrow]

cc @miabbott

[rphillips]

The cloud provider in the kubelet will gather the hostname from the metadata service (ie, aws, etc). Namely, this PR fixes the issue with metal or other non-cloud based platforms.

@cgwalters typhoon waits for the resolve.conf to get set [1], but I don't love the implementation.

1. https://github.com/poseidon/typhoon/blob/24fc440d837afceb189986c5375b68d8ce84ce50/bare-metal/container-linux/kubernetes/cl/worker.yaml.tmpl#L17

[cgwalters]

The cloud provider in the kubelet will gather the hostname from the metadata service (ie, aws, etc).

😱 There's another codebase doing that?

[rphillips]

@cgwalters same code base as the kubelet, but each cloud provider does the hostname detection slightly different [source].

[jlebon]

/approve

[rphillips]

/retest

[kikisdeliveryservice]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, jlebon, kikisdeliveryservice, miabbott, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ashcrow,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rphillips]

level=error msg="Error: Error creating S3 bucket: timeout while waiting for state to become 'success' (timeout: 5m0s)"
level=error
level=error msg="  on ../tmp/openshift-install-518815423/bootstrap/main.tf line 5, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg="   5: resource \"aws_s3_bucket\" \"ignition\" {"

[rphillips]

/retest

[openshift-ci-robot]

@rphillips: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	bce770d	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rphillips: All pull requests linked via external trackers have merged. Bugzilla bug 1763700 has been moved to the MODIFIED state.

In response to this:

Bug 1763700: kubelet: add dependency on network-online.target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/cherrypick release-4.2

[openshift-cherrypick-robot]

@runcom: new pull request created: #1212

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.