Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: wait for network-online to start kubelet #2549

Closed

Conversation

rphillips
Copy link
Contributor

Fixes a race when the kubelet starts up to enumerate the hostname.

Ports over a change from the MCO.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1763700
ref: openshift/machine-config-operator#1206

holding until the MCO PR merges in.
/hold

Fixes a race when the kubelet starts up to enumerate the hostname.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1763700
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@abhinavdahiya
Copy link
Contributor

How is this bug useful to the bootstrap kubelet service, we don't configure it to connect to any API.

@rphillips
Copy link
Contributor Author

I am just thinking of parity with the MCO.

@openshift-ci-robot
Copy link
Contributor

@rphillips: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 6c34db7 link /test e2e-aws
ci/prow/e2e-aws-upgrade 6c34db7 link /test e2e-aws-upgrade
ci/prow/e2e-aws-scaleup-rhel7 6c34db7 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member

Yeah, I requested this just because in the past we've let the installer copy drift. But you're also right this particular change probably doesn't matter. So, shrug - no real strong opinion from me.

@rphillips
Copy link
Contributor Author

Going to close this... We can reopen if we need to.

@rphillips rphillips closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants