Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace tectonicClusterID tag with openshiftClusterID #147

Merged
merged 1 commit into from
Dec 13, 2018
Merged

replace tectonicClusterID tag with openshiftClusterID #147

merged 1 commit into from
Dec 13, 2018

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Dec 7, 2018

The tectonicClusterID tag is being replaced with openshiftClusterID in the installer. This change will use the new tag name.

/hold on openshift/installer#817

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2018
@staebler
Copy link
Contributor Author

staebler commented Dec 7, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2018
@staebler staebler mentioned this pull request Dec 7, 2018
Merged
@staebler
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2018
@staebler
Copy link
Contributor Author

/retest

@staebler
Copy link
Contributor Author

/test integration

@ingvagabund
Copy link
Member

/retest

@ingvagabund
Copy link
Member

per comments in openshift/installer#817 (comment):

As part of removing references to tectonic, the tectonicClusterID tags will
be changed to openshiftClusterID. This is the first part of that.

This creates the openshiftClusterID tag that will be laid down alongside the
tectonicClusterID tag.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2018
@openshift-merge-robot openshift-merge-robot merged commit de7af79 into openshift:master Dec 13, 2018
@staebler staebler deleted the remove_tectonic_references branch December 13, 2018 13:01
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#147 from enxebre/openshift-machine-api
9a983a5 
Openshift machine api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@staebler @ingvagabund @openshift-ci-robot @openshift-merge-robot