-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: mirror tectonicClusterID as openshiftClusterID #817
*: mirror tectonicClusterID as openshiftClusterID #817
Conversation
/test e2e-aws |
As part of removing references to tectonic, the tectonicClusterID tags will be changed to openshiftClusterID. This is the first part of that. This creates the openshiftClusterID tag that will be laid down alongside the tectonicClusterID tag. After all of the usages of tectonicClusterID in other repos are removed, then the tectonicClusterID will be removed, leaving only the openshiftClusterID. https://jira.coreos.com/browse/CORS-878
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
e2e-aws first error:
Dunno what's up with that. /retry |
/test e2e-aws |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Through e810901 (Merge pull request openshift#817 from staebler/add_openshiftClusterID, 2018-12-10, openshift#822).
This worked previously since we only had one tag in the filter but since we added both via openshift#817 we exposed a bug which is we should break after matching any key since we've deleted the things and don't need to iterate over the filter keys anymore.
As part of removing references to tectonic, the tectonicClusterID tags will
be changed to openshiftClusterID. This is the first part of that. This
creates the openshiftClusterID tag that will be laid down alongside the
tectonicClusterID tag. After all of the usages of tectonicClusterID in other
repos are removed, then the tectonicClusterID will be removed, leaving only
the openshiftClusterID.
https://jira.coreos.com/browse/CORS-878