UPSTREAM: <carry>: openshift: use ProviderID for node lookup #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the mapping between a node and a machine to rely on the presence of the ProviderID rather than the "machine" annotation currently added by the nodelink-controller. Note: this should not merge until we update the AWS, libvirt and kubemark actuators - they should ensure that ProviderID is set, if not already, on the machine object.
Reimplement findNodeByNodeName as findNodeByProviderID.
openshift-ci-robot
added
the
size/L
|
/hold Waiting for #97 to merge. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold Also going to fallback to using the machine annotation as this will help with actuators that are not backed by a cloud-provider (e..g, libvirt). |
|
Closing in favour of #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement
findNodeByNodeName()asfindNodeByProviderID(), using theProviderIDindex.Builds on top of #97.