UPSTREAM: <carry>: openshift: drop machine annotation linkage #97
Conversation
openshift-ci-robot
added
the
size/M
|
/hold Expecting e2e tests to fail as not all actuators are propagating or setting |
openshift-ci-robot
added
the
do-not-merge/hold
|
AWS PR for setting ProviderID: openshift/cluster-api-provider-aws#210 |
|
I successfully tested this change against openshift/cluster-api-provider-aws#210. Once that is in a payload I think this is good to merge. |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/cc @ingvagabund @enxebre |
frobware
force-pushed
the
drop-machine-annotation-requirement
branch
from
3550c7b to
32f06b2
Compare
This changes the mapping between a node and a machine to rely on the presence of the ProviderID rather than the "machine" annotation currently added by the nodelink-controller. Note: this should not merge until we update the AWS, libvirt and kubemark actuators - they should ensure that ProviderID is set, if not already, on the machine object.
frobware
force-pushed
the
drop-machine-annotation-requirement
branch
from
32f06b2 to
9a30ba1
Compare
|
@frobware: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
For backwards compatibility we are going to keep the machine annotation but now moving parts of this PR to #99. |
This changes the mapping between a node and a machine to rely on the
presence of the ProviderID rather than the "machine" annotation
currently added by the nodelink-controller.
Note: this should not merge until we update the AWS, libvirt and
kubemark actuators - they should ensure that ProviderID is set, if not
already, on the machine object.