Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1906933: Add upstream patch for update group identifier #184

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Bug 1906933: Add upstream patch for update group identifier #184

merged 1 commit into from
Dec 15, 2020

Conversation

elmiko
Copy link

@elmiko elmiko commented Dec 1, 2020

this pr brings in the patch for update group identifiers, see kubernetes#3161

@elmiko
Copy link
Author

elmiko commented Dec 1, 2020

opening this as a draft for now, it will need to wait until #180 merges

@elmiko elmiko mentioned this pull request Dec 1, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

JoelSpeed
JoelSpeed reviewed Dec 8, 2020
View reviewed changes
Copy link

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@elmiko elmiko force-pushed the openshift/add-updated-group-identifier branch from ea592d5 to 8e24c82 Compare December 10, 2020 14:59
@elmiko
Copy link
Author

elmiko commented Dec 10, 2020

rebased after 180 merged

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko elmiko marked this pull request as ready for review December 10, 2020 14:59
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@elmiko
Copy link
Author

elmiko commented Dec 10, 2020

/test goimports

@detiber @elmiko
UPSTREAM: <drop>: openshift: Update group identifier to use for Clust…
9957211 
…er API annotations

- Also add backwards compatibility for the previously used deprecated annotations
@elmiko elmiko force-pushed the openshift/add-updated-group-identifier branch from 8e24c82 to 9957211 Compare December 10, 2020 19:05
@elmiko
Copy link
Author

elmiko commented Dec 10, 2020

updated to address goimport failure, it looks like there was some bad formatting in a couple files.

@elmiko
Copy link
Author

elmiko commented Dec 10, 2020

/retest

@elmiko elmiko changed the title Add upstream patch for update group identifier Bug 1906933: Add upstream patch for update group identifier Dec 11, 2020
@elmiko
Copy link
Author

elmiko commented Dec 11, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020
@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1906933, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906933: Add upstream patch for update group identifier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1906933, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e5007c3 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1906933 has been moved to the MODIFIED state.

In response to this:

Bug 1906933: Add upstream patch for update group identifier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the openshift/add-updated-group-identifier branch May 24, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elmiko @openshift-ci-robot @JoelSpeed @openshift-bot @openshift-merge-robot @detiber