Add upstream patch for --cloud-config option #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
opening this as draft because it needs the chain ending with #179 before it can merge, and there are 2 big commits that need to be merged. |
openshift-ci-robot
added
the
needs-rebase
elmiko
force-pushed
the
openshift/add-cloud-config
branch
from
dde0e46 to
a3bf8d1
Compare
openshift-ci-robot
removed
the
needs-rebase
|
rebased |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
this is ready for review, but still needs to wait for #179 |
openshift-ci-robot
added
the
do-not-merge/hold
elmiko
force-pushed
the
openshift/add-cloud-config
branch
from
a3bf8d1 to
d45f4f8
Compare
|
this should go before #184 |
JoelSpeed
reviewed
Dec 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
…api provider - Leverage --cloud-config to allow for providing a separate kubeconfig for Cluster API management and workload cluster resources - Allow for fallback to previous behavior when --cloud-config is not specified for backward compatibility - Provides a --clusterapi-cloud-config-authoritative flag to disable the above fallback behavior and allow for both the management and workload cluster clients to use the in-cluster config
elmiko
force-pushed
the
openshift/add-cloud-config
branch
from
d45f4f8 to
61b8048
Compare
|
rebased after 179 merged |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings in the upstream patch kubernetes#3203