Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-41813: Validate MTU for custom network #9104

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[release-4.16] OCPBUGS-41813: Validate MTU for custom network #9104

merged 2 commits into from
Dec 9, 2024

Conversation

mandre
Copy link
Member

@mandre mandre commented Oct 17, 2024

This is manual cherry-pick of #8988 and #9081.

mandre added 2 commits October 17, 2024 10:00
@mandre
Validate MTU for custom network
8ef87a5 
Set the minimum MTU to 1380 when deploying on IPv6. This value
corresponds to the minimum MTU for IPv6, which is 1280, and the
ovn-kubernetes overhead, which is 100.
@mandre
Validate MTU when controlPlanePort uses FixedIPs
401c0d7 
The minimum MTU for the IPv6 network was previously only enforced when
the controlPlanePort used the Network filter. This commit change the
validation to also work when using the Subnet filter from FixedIPs.

This commit does two things:
- populate the ControlPlanePortNetwork struct in CloudInfo even when
  using the Subnet filter and not the Network one.
- move the validation for MTU out of the branch for Network filter from
  the install-config.yaml
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 17, 2024
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-41813, which is invalid:

  • expected dependent Jira Issue OCPBUGS-41812 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is manual cherry-pick of #8988 and #9081.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre
Copy link
Member Author

mandre commented Oct 17, 2024

/jira backport release-4.15

@openshift-ci-robot
Copy link
Contributor

@mandre: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.15

In response to this:

/jira backport release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

@mandre: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.15

In response to this:

/jira backport release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mandre
Copy link
Member Author

mandre commented Nov 20, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-41813, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-41812 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-41812 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre
mandre commented Nov 20, 2024
View reviewed changes
Copy link
Member Author

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 20, 2024
@sadasu
Copy link
Contributor

sadasu commented Nov 25, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@EmilienM
Copy link
Member

/lgtm
e2e failures are unrelated.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@mandre
Copy link
Member Author

mandre commented Nov 25, 2024

/assign @rlobillo

@eurijon
Copy link

eurijon commented Dec 2, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a7d7c9c and 2 for PR HEAD 401c0d7 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a7d7c9c and 2 for PR HEAD 401c0d7 in total

@sadasu
Copy link
Contributor

sadasu commented Dec 2, 2024

/test e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a7d7c9c and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a7d7c9c and 2 for PR HEAD 401c0d7 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a7d7c9c and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 1 for PR HEAD 401c0d7 in total

@mandre
Copy link
Member Author

mandre commented Dec 4, 2024

e2e-openstack-ovn failed to create a manila share, this is a know issue that was caused by recent CI infra changes. We have a fix at openshift/openstack-test#205 that will need to merge in 4.16.

Until then,
/override ci/prow/e2e-openstack-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@mandre: mandre unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

e2e-openstack-ovn failed to create a manila share, this is a know issue that was caused by recent CI infra changes. We have a fix at openshift/openstack-test#205 that will need to merge in 4.16.

Until then,
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mandre
Copy link
Member Author

mandre commented Dec 4, 2024

@sadasu, could you override ci/prow/e2e-openstack-ovn please? There's a known issue with the CI test that is failing.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

8 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c152a74 and 2 for PR HEAD 401c0d7 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024 •
edited
Loading

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 401c0d7 link false /test e2e-openstack-proxy
ci/prow/okd-scos-e2e-vsphere-ovn 401c0d7 link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented Dec 9, 2024

The fix has merged in 4.16 (openshift/openstack-test#208), and now we expect e2e-openstack-ovn to pass.
/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 24cd6e3 into openshift:release-4.16 Dec 9, 2024
21 of 23 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the mtu-validation-4.16 branch December 9, 2024 19:39
@openshift-ci-robot
Copy link
Contributor

@mandre: Jira Issue OCPBUGS-41813: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41813 has been moved to the MODIFIED state.

In response to this:

This is manual cherry-pick of #8988 and #9081.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: new pull request created: #9294

In response to this:

@mandre: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.15

In response to this:

/jira backport release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2024
Open
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.16.0-202412092005.p0.g24cd6e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.16.0-202412092005.p0.g24cd6e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202412092005.p0.g24cd6e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.16.0-202412092005.p0.g24cd6e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-12-11-055812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@EmilienM EmilienM

@rlobillo rlobillo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mandre @openshift-ci-robot @openshift-cherrypick-robot @sadasu @EmilienM @eurijon @openshift-bot @openshift-merge-robot @rlobillo