OCPBUGS-41785: Validate MTU when controlPlanePort uses FixedIPs

[mandre]

The minimum MTU for the IPv6 network was previously only enforced when the controlPlanePort used the Network filter. This commit change the validation to also work when using the Subnet filter from FixedIPs.

This commit does two things:

• populate the ControlPlanePortNetwork struct in CloudInfo even when using the Subnet filter and not the Network one.
• move the validation for MTU out of the branch for Network filter from the install-config.yaml

[openshift-ci-robot]

@mandre: This pull request references Jira Issue OCPBUGS-41785, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The minimum MTU for the IPv6 network was previously only enforced when the controlPlanePort used the Network filter. This commit change the validation to also work when using the Subnet filter from FixedIPs.

This commit does two things:

• populate the ControlPlanePortNetwork struct in CloudInfo even when using the Subnet filter and not the Network one.
• move the validation for MTU out of the branch for Network filter from the install-config.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pierreprinetti]

Looks legit, but I think I'll need the CI results to build a bit more confidence

/approve
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/openstack/OWNERS [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mandre]

/hold cancel

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7534652 and 2 for PR HEAD 3ab8bca in total

[openshift-ci]

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-nfv-intel	3ab8bca	link	false	/test e2e-openstack-nfv-intel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@mandre: Jira Issue OCPBUGS-41785: All pull requests linked via external trackers have merged:

• openshift/installer#8988
• openshift/installer#9081

Jira Issue OCPBUGS-41785 has been moved to the MODIFIED state.

In response to this:

The minimum MTU for the IPv6 network was previously only enforced when the controlPlanePort used the Network filter. This commit change the validation to also work when using the Subnet filter from FixedIPs.

This commit does two things:

• populate the ControlPlanePortNetwork struct in CloudInfo even when using the Subnet filter and not the Network one.
• move the validation for MTU out of the branch for Network filter from the install-config.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.