Bug 2085187: terraform: revendor golang.org/x/sys #5896
Conversation
|
Looks like the same versions were used from #5865 |
|
/lgtm |
|
/retest |
|
Are there upstream fixes for this? |
|
random: our version is behind, latest upstream version builds fine with 1.18 |
|
@yselkowitz your upstream ignition PR merged. Instead of revendoring x/sys locally can we bring in the new versions of these providers with the proper x/sys support? |
Among other changes, this fixes the build on Mac OS with Go 1.18 by revendoring golang.org/x/sys.
This is needed to build for Mac OS with Go 1.18, backport of: community-terraform-providers/terraform-provider-ignition#19
|
For ignition, no new version has been spun, but the revendoring would be the only upstream code change, so that still seems appropriate. For random, a rebase to v3.1.3 was more than I bargained for, but if you insist... |
yselkowitz
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@yselkowitz: This pull request references Bugzilla bug 2085187, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest |
|
/assign @staebler |
|
@yselkowitz: GitHub didn't allow me to assign the following users: staebler. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jstuever |
|
/assign @patrickdillon @sdodson |
|
@yselkowitz Do we ship builds built via this method or do we cross compile? Just trying to gauge urgency here. |
|
yes, this affects the build of installer-artifacts, which is currently behind installer and the rest of OCP as a result. |
This is urgent. ART is currently making an exception to build installer with go 1.18 until we get this merged. Thanks @yselkowitz for your work on this. |
|
/test e2e-vsphere-upi |
|
Azure uses the random provider and e2e-azure passed. Testing vsphere-upi because it uses ignition, but through a different method than OpenStack. /approve Assuming ignition provider initializes with vsphere-upi we can LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@patrickdillon e2e-vsphere-upi passed |
|
/lgtm |
|
@yselkowitz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
@yselkowitz: All pull requests linked via external trackers have merged: Bugzilla bug 2085187 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The compile issue with 1.18 for darwin targets should be fixed by openshift/installer#5896
Bug 2085187: terraform: revendor golang.org/x/sys
This is necessary for these providers to build for Mac with Go 1.18.
golang/go#51706