Bump Azure Stack Terraform Provider for Go 1.18

[patrickdillon]

Builds for Mac are failing with Go 1.18 due to an outdated dependency in the Azure Stack Terraform provider on x/sys: golang/go#49219

I tested this using registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.18-openshift-4.11 and it resolves the issue.

[patrickdillon]

Let's make sure e2e-azurestack gets a successful terraform run.

[patrickdillon]

/retest

[patrickdillon]

The goal here is to ensure compatibility with Go 1.18, but not yet require it.

[patrickdillon]

Prior to this change, building the provider is failing similar to this:

sh-4.4# GOOS=darwin make
==> Checking that code complies with gofmt requirements...
go install
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:121:3: too many errors
make: *** [GNUmakefile:19: build] Error 2

[barbacbd]

Sifted through the files and there was only the one go.mod file changed. Verified the version of sys that was updated.

[barbacbd]

/lgtm

[patrickdillon]

Reran with go mod tidy -compat=1.17 to fix failing verify-vendor test.

[barbacbd]

/lgtm

[sadasu]

/test e2e-azurestack

[patrickdillon]

e2e-azurestack tests are successfully running terraform. failure is after bootstrap complete.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted	6badee4	link	false	/test e2e-metal-assisted
ci/prow/e2e-azure-shared-vpc	6badee4	link	false	/test e2e-azure-shared-vpc
ci/prow/okd-e2e-aws	6badee4	link	false	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.