Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/data/rhcos.json: update the bootimage to 420.8.20190708.2 for CRI-O 1.14 #1941

Merged
merged 1 commit into from
Jul 9, 2019
Merged

data/data/rhcos.json: update the bootimage to 420.8.20190708.2 for CRI-O 1.14 #1941

merged 1 commit into from
Jul 9, 2019

Conversation

abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya requested a review from ashcrow July 3, 2019 18:58
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2019
@ashcrow
Copy link
Member

ashcrow commented Jul 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow
Copy link
Member

ashcrow commented Jul 3, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2019
@ashcrow
Copy link
Member

ashcrow commented Jul 3, 2019

@abhinavdahiya pointed out that ssh is failing with this AMI. The same artifacts on libvirt or qemu work correctly (hence the added hold)

@praveenkumar
Copy link
Contributor

/test e2e-libvirt

@abhinavdahiya abhinavdahiya force-pushed the bump_rhcos_for_crio branch from 64d0ffc to 905db73 Compare July 8, 2019 22:32
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@abhinavdahiya abhinavdahiya changed the title data/data/rhcos.json: update the bootimage to 420.8.20190703.0 for CRI-O 1.14 data/data/rhcos.json: update the bootimage to 420.8.20190708.2 for CRI-O 1.14 Jul 8, 2019
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

the cluster create succeeded.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
@abhinavdahiya
Copy link
Contributor Author

ping @ashcrow

@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

@cgwalters
Copy link
Member

Failures in openstack and scaleup seem unlikely to be related.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 79714be into openshift:master Jul 9, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 905db73 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Jul 10, 2019
Merged
Closed
hardys referenced this pull request Jul 10, 2019
@stbenjam @cybertron
@markmc @russellb
data/data/bootstrap/baremetal: add baremetal-specific configuration
90d7a15 
The baremetal platform (IPI for Bare Metal hosts) includes some
additional assets on the bootstrap node for automating some
infrastructure requirements that would have normally been handled by
some cloud infrastructure service. See
data/data/bootstrap/baremetal/README.md for more detailed documentation.

Co-authored-by: Ben Nemec <[email protected]>
Co-authored-by: Mark McLoughlin <[email protected]>
Co-authored-by: Russell Bryant <[email protected]>
Co-authored-by: Stephen Benjamin <[email protected]>
Co-authored-by: Steven Hardy <[email protected]>
@hardys hardys mentioned this pull request Jul 24, 2019
Merged
This was referenced Sep 3, 2019
Closed
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Sep 3, 2019
@wking
pkg/types/aws/validation/platform: Include eu-north-1
c907d53 
RHCOS grew support for this in 905db73 (data/data/rhcos.json:
update the bootimage to 420.8.20190708.2 for CRI-O 1.14, 2019-07-03, openshift#1941).
And until we get something like [1], we need this not-very-DRY bump to
keep up.

[1]: openshift#1528
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/installer that referenced this pull request Oct 24, 2019
@wking
pkg/types/aws/validation/platform: Include eu-north-1
fcf7394 
RHCOS grew support for this in 905db73 (data/data/rhcos.json:
update the bootimage to 420.8.20190708.2 for CRI-O 1.14, 2019-07-03, openshift#1941).
And until we get something like [1], we need this not-very-DRY bump to
keep up.

[1]: openshift#1528
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Dec 6, 2019
@wking @jhixson74
pkg/types/aws/validation/platform: Include eu-north-1
aaed41e 
RHCOS grew support for this in 905db73 (data/data/rhcos.json:
update the bootimage to 420.8.20190708.2 for CRI-O 1.14, 2019-07-03, openshift#1941).
And until we get something like [1], we need this not-very-DRY bump to
keep up.

[1]: openshift#1528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@ashcrow ashcrow

@cgwalters cgwalters

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abhinavdahiya @ashcrow @openshift-bot @praveenkumar @cgwalters @openshift-ci-robot @openshift-merge-robot