-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bmo 20190708 #36
update bmo 20190708 #36
Conversation
This updates the vendored copy of baremetal-operator to remove the machineRef field.
update baremetal-operator to remove machineRef
/cc @russellb |
I think some recent fixes from @zaneb landed so should we update this to include those? @dhellmann @russellb I'd like to rebase kni-installer again this week to pick up openshift/installer#1941 so it'd be good to ensure all the openshift forks are updated before we do that. |
As a general process thing, I've been creating these date-based PRs so we can just take them incrementally. So I could close this one and open a new one with the full content, or we could take this one and I could open another with the new delta. Let me know which you prefer. |
i'm fine landing this, and then a follow-up PR. This shouldn't cause a problem AFAIK ... /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to the version of the baremetal-operator that completes the work to rename machineRef to consumerRef.