Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.upi.ci: declari cli image as input image #1497

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

vrutkovs
Copy link
Member

Fix Dockerfile.upi.ci syntax - image has to be in FROM before COPY --from is used

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2019
@abhinavdahiya
Copy link
Contributor

This was working as when I tested it locally. What's the failure?

@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 29, 2019

Fails during a test run in CI:

+ go build -ldflags ' -X github.com/openshift/installer/pkg/version.Raw=unreleased-master-656-g9d0a9d0e92971f8d3b226f0ec693fb965f1d837c-dirty -X github.com/openshift/installer/pkg/version.Commit=9d0a9d0e92971f8d3b226f0ec693fb965f1d837c -s -w -X github.com/openshift/installer/pkg/rhcos.buildName=410.8.20190325.0' -tags ' release' -o bin/openshift-install ./cmd/openshift-install
--> FROM docker-registry.default.svc:5000/ci-op-krknwzjz/pipeline@sha256:3eea282ed886c5f958b44856a06bb01b90fb684190cf9f5da6eaf2f2ddd99ee8 as 1 
--> COPY --from=registry.svc.ci.openshift.org/openshift/origin-v4.0:cli /usr/bin/oc /bin/oc 
error: build error: no such image 

Could be some imagebuilder quirk

@abhinavdahiya
Copy link
Contributor

Fails during a test run in CI:

+ go build -ldflags ' -X github.com/openshift/installer/pkg/version.Raw=unreleased-master-656-g9d0a9d0e92971f8d3b226f0ec693fb965f1d837c-dirty -X github.com/openshift/installer/pkg/version.Commit=9d0a9d0e92971f8d3b226f0ec693fb965f1d837c -s -w -X github.com/openshift/installer/pkg/rhcos.buildName=410.8.20190325.0' -tags ' release' -o bin/openshift-install ./cmd/openshift-install
--> FROM docker-registry.default.svc:5000/ci-op-krknwzjz/pipeline@sha256:3eea282ed886c5f958b44856a06bb01b90fb684190cf9f5da6eaf2f2ddd99ee8 as 1 
--> COPY --from=registry.svc.ci.openshift.org/openshift/origin-v4.0:cli /usr/bin/oc /bin/oc 
error: build error: no such image 

Could be some imagebuilder quirk

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 58a2767 into openshift:master Mar 29, 2019
wking added a commit to wking/openshift-installer that referenced this pull request Apr 2, 2019
Through 58a2767 (Merge pull request openshift#1497 from
vrutkovs/upi-multistage-cli, 2019-03-29).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants