Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Vsphere upi test #1495

Closed
wants to merge 3 commits into from
Closed

WIP Vsphere upi test #1495

wants to merge 3 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Mar 29, 2019 •
edited
Loading

Required fixes to make CI for vsphere UPI pass

This PR was created to test new CI template and configuration, it consists of cherrypicks from other PRs and won't ever be merged

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wking

If they are not already assigned, you can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhinavdahiya
abhinavdahiya reviewed Mar 29, 2019
View reviewed changes
images/installer/Dockerfile.upi.ci Outdated
@@ -8,8 +8,10 @@ WORKDIR /go/src/github.com/openshift/installer
COPY . .
RUN hack/build.sh

FROM registry.svc.ci.openshift.org/openshift/origin-v4.0:cli as cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change already merged #1497 why am i still seeing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't rebase yet, sorry.

This PR is just for CI testing, so that all fixes would be in a single PR. I'll be cherrypicking changes from here to separate PRs if required

abhinavdahiya
abhinavdahiya reviewed Mar 29, 2019
View reviewed changes
images/installer/Dockerfile.upi.ci
@@ -23,7 +23,7 @@ RUN yum install --setopt=tsflags=nodocs -y \
openssh-clients && \
yum update -y && \
yum install --setopt=tsflags=nodocs -y \
unzip gzip jq awscli util-linux && \
unzip gzip awscli util-linux && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a reason why we are dropping jq ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI can't install epel-release and has an issue with internal repos, so upi-installer build fails with it.

@stevekuznetsov is looking at it afaik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarterclayton where do the devel-4.0 rpm repos come from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for this started to see them unreachable

staebler and others added 3 commits April 1, 2019 13:55
@staebler @vrutkovs
upi/vsphere: add dns for control plane and compute hostnames
99281dd 
Add DNS records for the control plane and compute hostnames so that
they are resolvable from within the cluster.
@staebler @vrutkovs
upi/vsphere: get ip addresses from vmtools
9868b9c 
With the recent rhcos, vmtools is running on the VMs, allowing
terraform to obtain the IP addresses assigned. The user no longer
needs to acquire the IP addresses manually.
@vrutkovs
Dockerfile.upi.ci: temporarily drop jq
db14a4f
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2019
@vrutkovs
Copy link
Member Author

vrutkovs commented Apr 8, 2019

No longer required

@vrutkovs vrutkovs closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@hardys hardys Awaiting requested review from hardys

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vrutkovs @openshift-ci-robot @abhinavdahiya @stevekuznetsov @staebler