hack/gotest.sh: Drop unnecessary script #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
|
/hold I've got a WIP commit in here with a Go test violation to show Prow noticing the issue. Once we have that confirmed, I'll remove that WIP commit before we land this. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel Here's the error: |
openshift-ci-robot
removed
the
do-not-merge/hold
wking
force-pushed
the
drop-go-test-script
branch
from
19c49b6 to
f4b5df8
Compare
|
@wking thanks for taking care of this, indeed we do not need this script, we did not know of the ci-operator job when we originally picked up the task of converting all travis jobs to prow 👍 |
The script is from b8a9bbc (Remove bazel from test process, 2018-08-01, openshift#97), as part of moving tests from Travis to Prow. But Prow is already running our Go unit tests, via pull-ci-origin-installer-unit [1] with this config [2]. It's had that setup since openshift/release@eb11aa8b (Bump config to take advantage of canonical setup, 2018-06-06, openshift/release#921), so we don't need to replicate it here. [1]: https://github.com/openshift/release/blob/6f623b15854ae91203243af22d7a259ab85acd86/ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml#L3-L28 [2]: https://github.com/openshift/release/blob/6f623b15854ae91203243af22d7a259ab85acd86/ci-operator/config/openshift/installer/master.json#L44
wking
force-pushed
the
drop-go-test-script
branch
from
f4b5df8 to
a4187f6
Compare
|
Rebased around #118 now that that's landed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script is from b8a9bbc (Remove bazel from test process, 2018-08-01, #97), as part of moving tests from Travis to Prow. But Prow is already running our Go unit tests, via
pull-ci-origin-installer-unitwith this config. It's had that setup since openshift/release@eb11aa8b (openshift/release#921), so we don't need to replicate it here.