Prow: add golint hack script

[alejovicu]

• Add hack script to run Go lint
• Update Travis to use this script

[wking]

With both of my recommended changes, the script becomes something like:

#!/bin/sh
if [ "$IS_CONTAINER" != "" ]; then
  golint -set_exit_status installer/...
else
  docker run --rm --env IS_CONTAINER='TRUE' -v "$PWD":/go/src/github.com/openshift/installer -w /go/src/github.com/openshift/installer --entrypoint sh quay.io/coreos/golang-testing /go/src/github.com/openshift/installer/hack/go-lint.sh
fi

[wking]

I'd rather drop this cd and keep the -w approach we have in Travis now. Restricting absolute path opinions to the empty-$IS_CONTAINER branch makes it easier to run this script without containerization on hosts with their own golint.

[wking]

Master is currently only linting under installer/..., so there's no need to involve find or vendor-exclusion.

[alejovicu]

In this case the /tests path, that also contains .go files, will not be covered by golint. Should we skip this check?

[wking]

In this case the /tests path...

We don't currently lint those, but I'd be fine extending to:

golint -set_exit_status ./installer/... ./tests/...

I think whitelisting is easy and stable enough to make it preferable to a blacklist approach that involves find, although I'd be fine with a blacklist approach if golint supported it directly with something like:

golint -set_exit_status -exclude vendor ./...

However, it looks like golint currently has no such vendor-exclusion option (golang/lint#320, golang/lint#325).

[alejovicu]

/assign @wking

[wking]

nit: you're setting the working directory explicitly with -w, so you should be able to use ./hack/go-lint.sh as the final argument instead of the absolute path you have now. That would also more closely match the pattern used by our existing hack scripts:

$ git describe --always --abbrev=0
5ac7cfb476972284e7dd25bc14d8d82442f439bc
$ grep 'docker.*hack/' hack/*.sh
hack/gotest.sh:  docker run -e IS_CONTAINER='TRUE' -v "$PWD":/go/src/github.com/openshift/installer -w /go/src/github.com/openshift/installer quay.io/coreos/golang-testing ./hack/gotest.sh
hack/go-vet.sh:    docker run --rm --env IS_CONTAINER='TRUE' -v "$PWD":/go/src/github.com/openshift/installer -w /go/src/github.com/openshift/installer quay.io/coreos/golang-testing ./hack/go-vet.sh "$dir"
hack/shellcheck.sh:  docker run -e IS_CONTAINER='TRUE' --rm -v "$(pwd)":/workdir:ro --entrypoint sh quay.io/coreos/shellcheck-alpine:v0.5.0 /workdir/hack/shellcheck.sh /workdir;
hack/test-bazel-build-tarball.sh:  docker run -e IS_CONTAINER='TRUE' --rm -v "$PWD":"$PWD" -v /tmp:/tmp:rw -w "$PWD" quay.io/coreos/tectonic-builder:bazel-v0.3 ./hack/test-bazel-build-tarball.sh
hack/tf-fmt.sh:  docker run -e IS_CONTAINER='TRUE' --rm -v "$PWD":"$PWD":ro -v /tmp:/tmp:rw -w "$PWD" quay.io/coreos/terraform-alpine:v0.11.7 ./hack/tf-fmt.sh
hack/tf-lint.sh:  docker run -t --rm -v "$(pwd)":/data --env IS_CONTAINER='TRUE' --entrypoint sh quay.io/coreos/tflint ./hack/tf-lint.sh
hack/yaml-lint.sh:  docker run -t --rm -v "$(pwd)":/workdir --env IS_CONTAINER='TRUE' --entrypoint sh quay.io/coreos/yamllint ./hack/yaml-lint.sh

[wking]

You've updated the script to use "${1:-.}", so you should update this to pass in installer/....

[wking]

nit: I'd prefer "${@}" to ${1:-.}" so we can pass multiple paths. But as long as we're only linting installer/..., both approaches are fine.

[wking]

I'd like to keep the script sig the same regardless of IS_CONTAINER. so whatever you use in the earlier block (${@} or ${1:-.}), you should use here too.

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejovicu, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment