Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove the double @sha256 in case the image name is already digest base" #1269

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

wking
Copy link
Member

@wking wking commented Feb 19, 2019

This reverts commit bc59aaf, #1032.

We don't need this any more after Podman was bumped to 1.0.1 in RHCOS 47.317:

$ curl -s https://releases-redhat-coreos.cloud.paas.upshift.redhat.com/storage/releases/maipo/47.317/meta.json | jq .pkgdiff
[
  [
    "podman",
    2,
    {
      "NewPackage": [
        "podman",
        "1.0.1-2.git921f98f.el7",
        "x86_64"
      ],
      "PreviousPackage": [
        "podman",
        "1.0.0-3.git921f98f.el7",
        "x86_64"
      ]
    }
  ]
]

pulling in containers/podman@53e70e26 (containers/podman#2251).

…igest base"

This reverts commit bc59aaf.

We don't need this any more after Podman was bumped to 1.0.1 in RHCOS
47.317:

  $ curl -s https://releases-redhat-coreos.cloud.paas.upshift.redhat.com/storage/releases/maipo/47.317/meta.json | jq .pkgdiff
  [
    [
      "podman",
      2,
      {
        "NewPackage": [
          "podman",
          "1.0.1-2.git921f98f.el7",
          "x86_64"
        ],
        "PreviousPackage": [
          "podman",
          "1.0.0-3.git921f98f.el7",
          "x86_64"
        ]
      }
    ]
  ]

pulling in containers/podman@53e70e26 (libpod/image: Use RepoDigests()
in Inspect(), 2019-01-31).
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2019
@crawford
Copy link
Contributor

A whole bunch of the following in the logs:

dial tcp: lookup api.ci-op-3w5235sj-1d3f3.origin-ci-int-aws.dev.rhcloud.com on 10.142.0.54:53: no such host

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8dd7e3f into openshift:master Feb 19, 2019
@wking wking deleted the podman-1.0.1 branch February 26, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants