Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the double @sha256 in case the image name is already digest base #1032

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

lveyde
Copy link
Contributor

@lveyde lveyde commented Jan 9, 2019

Due to the issue in podman it seems to incorrectly return digests with
double @sha256 in the name.

This patch fixes the issue in the bootkube.sh to remove double occurances
of @256 and replace it with single occurence, as normally expected.

I.e.
quay.io/openshift-release-dev/ocp-release@sha256@sha256:e237499d3b118e25890550daad8b17274af93baf855914a9c6f8f07ebc095dea

Reference to the issue:
#933

Signed-off-by: Lev Veyde [email protected]

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @lveyde. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2019
@wking
Copy link
Member

wking commented Jan 9, 2019

I think we can probably wait for containers/podman#2106 to percolate through into RHCOS (probably on Friday), but will leave open in case other maintainers want to land a stopgap here.

@wking
Copy link
Member

wking commented Jan 28, 2019

0.11.0 bumped to RHCOS 47.280 with Podman 1.0, so I think this is obsolete.

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

In response to this:

0.11.0 bumped to RHCOS 47.280 with Podman 1.0, so I think this is obsolete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k reopened this Feb 14, 2019
@deads2k
Copy link
Contributor

deads2k commented Feb 14, 2019

I'm seeing lots of stuck pulls. If this gets past the bootkube stage, i think we should merge it.

@abhinavdahiya
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2019
Due to the issue in podman it seems to incorrectly return digests with
double @sha256 in the name.

This patch fixes the issue in the bootkube.sh to remove double occurances
of @256 and replace it with single occurence, as normally expected.

I.e.
quay.io/openshift-release-dev/ocp-release@sha256@sha256:e237499d3b118e25890550daad8b17274af93baf855914a9c6f8f07ebc095dea

Reference to the issue:
openshift#933

Signed-off-by: Lev Veyde <[email protected]>
@lveyde lveyde force-pushed the fix-double-sha256-issue branch from 4dcd72e to bc59aaf Compare February 14, 2019 19:26
@wking
Copy link
Member

wking commented Feb 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lveyde, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@deads2k
Copy link
Contributor

deads2k commented Feb 14, 2019

button-ing in to help our queues

@deads2k deads2k merged commit d060bf4 into openshift:master Feb 14, 2019
@lveyde
Copy link
Contributor Author

lveyde commented Feb 14, 2019

I'm seeing lots of stuck pulls. If this gets past the bootkube stage, i think we should merge it.

Thanks David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants