-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the double @sha256 in case the image name is already digest base #1032
Conversation
Hi @lveyde. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think we can probably wait for containers/podman#2106 to percolate through into RHCOS (probably on Friday), but will leave open in case other maintainers want to land a stopgap here. |
0.11.0 bumped to RHCOS 47.280 with Podman 1.0, so I think this is obsolete. /close |
@wking: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm seeing lots of stuck pulls. If this gets past the bootkube stage, i think we should merge it. |
/ok-to-test |
Due to the issue in podman it seems to incorrectly return digests with double @sha256 in the name. This patch fixes the issue in the bootkube.sh to remove double occurances of @256 and replace it with single occurence, as normally expected. I.e. quay.io/openshift-release-dev/ocp-release@sha256@sha256:e237499d3b118e25890550daad8b17274af93baf855914a9c6f8f07ebc095dea Reference to the issue: openshift#933 Signed-off-by: Lev Veyde <[email protected]>
4dcd72e
to
bc59aaf
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lveyde, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
button-ing in to help our queues |
Thanks David. |
Due to the issue in podman it seems to incorrectly return digests with
double @sha256 in the name.
This patch fixes the issue in the bootkube.sh to remove double occurances
of @256 and replace it with single occurence, as normally expected.
I.e.
quay.io/openshift-release-dev/ocp-release@sha256@sha256:e237499d3b118e25890550daad8b17274af93baf855914a9c6f8f07ebc095dea
Reference to the issue:
#933
Signed-off-by: Lev Veyde [email protected]