assets/installconfig: apply defaults to install config #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
wking
force-pushed
the
defaults-for-installconfig
branch
from
2444a35 to
f3ffb86
Compare
openshift-ci-robot
removed
the
needs-rebase
|
The commit carried from #902 actually conflicted with changes that landed in master since #1057 branched off. So I've pushed 2444a35 -> f3ffb86 to rebase the two commits onto master. If #1057 lands before midnight, I'll rebase this again. If someone drops a |
and many more. Maybe my rebase broke something? /retest |
|
Logs from that busted osin pod: $ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1058/pull-ci-openshift-installer-master-e2e-aws/2845/artifacts/e2e-aws/pods/openshift-core-operators_origin-cluster-osin-operator2-7c95d6b586-f55tl_operator_previous.log.gz | gunzip | tail -n 13
ERROR: logging before flag.Parse: I0112 07:33:52.629752 1 leaderelection.go:209] successfully renewed lease openshift-core-operators/cluster-osin-operator2-lock
ERROR: logging before flag.Parse: I0112 07:33:54.651256 1 leaderelection.go:209] successfully renewed lease openshift-core-operators/cluster-osin-operator2-lock
panic: osins.osin.openshift.io "openshift-osin" is forbidden: caches not synchronized
goroutine 85 [running]:
github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/operator/v1helpers.EnsureOperatorConfigExists(0x1c2bf60, 0xc4200e6430, 0xc4208e2000, 0x91, 0xa0, 0x1a5e164, 0x11, 0x1a529f5, 0x8, 0x1a4e7be, ...)
/go/src/github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/operator/v1helpers/helpers.go:99 +0x34e
github.com/openshift/cluster-osin-operator/pkg/operator2.RunOperator(0xc420470f90, 0x0, 0x0)
/go/src/github.com/openshift/cluster-osin-operator/pkg/operator2/starter.go:83 +0x5a6
github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/controller/controllercmd.(*ControllerBuilder).Run.func2(0xc42051fb00)
/go/src/github.com/openshift/cluster-osin-operator/vendor/github.com/openshift/library-go/pkg/controller/controllercmd/builder.go:213 +0x4f
created by github.com/openshift/cluster-osin-operator/vendor/k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
/go/src/github.com/openshift/cluster-osin-operator/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:155 +0x92Dunno what was going on there, but once I find out, I'll file an upstream issue or PR. |
The panic is from this line, and openshift/library-go#168 may fix it (I'm not sure, but it mentions "fix panic" and syncing ;). |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
The Install Config asset will apply defaults to fields for which there are reasonable defaults. This applies to a generated Install Config asset and to an Install Config asset loaded from disk.
wking
force-pushed
the
defaults-for-installconfig
branch
from
f3ffb86 to
ec92355
Compare
|
Rebased onto master. No content changes. Still looks good to me. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
and more. /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Install Config asset will apply defaults to fields for which there are reasonable defaults. This applies to a generated Install Config asset and to an Install Config asset loaded from disk.
Carrying #902 onto #1057. CC @staebler, @abhinavdahiya, @crawford. Hold until #1057 lands:
/hold