Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend regeneration of install-config.yaml on upgrade #1016

Closed

Conversation

adambkaplan
Copy link

This ensures devs who re-use install-config.yaml templates deploy the latest "stable" RHCOS image.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: russellb

If they are not already assigned, you can assign the PR to them by writing /assign @russellb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jan 8, 2019

#902 will obsolete this (or at least call for much different wording). @staebler, any guesses about when you can get back to that? Should we land this stop-gap in the meantime?

@wking
Copy link
Member

wking commented Jan 25, 2019

#902 was carried in #1058, which landed two weeks ago. I think that obsoletes this wording, but please comment if you feel there is stuff that still needs to be documented :).

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

In response to this:

#902 was carried in #1058, which landed two weeks ago. I think that obsoletes this wording, but please comment if you feel there is stuff that still needs to be documented :).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants