Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: Migrate bootstrap assets to machine-config-operator #2067

Closed
russellb opened this issue Jul 22, 2019 · 3 comments
Closed

baremetal: Migrate bootstrap assets to machine-config-operator #2067

russellb opened this issue Jul 22, 2019 · 3 comments
Assignees
@cybertron
Labels
platform/baremetal IPI bare metal hosts platform

Comments

@russellb
Copy link
Member

bootkube already uses MCO to render other bootstrap assets. The idea here is to move the bootstrap assets for the baremetal platform from the installer to MCO.

A driving motivation behind this is that at install time, we're not able to get the right image pull spec for each of the services. By moving this to MCO, we can inspect the release image and pass the right pull specs to MCO, similar to what bootkuke does to get other images.

This will also keep maintenance of all of these assets in one place, since they're similar to assets placed on masters and workers.

Here's a related WIP PR that was posted to the old kni installer fork: openshift-metal3/kni-installer#126
@russellb russellb added the platform/baremetal IPI bare metal hosts platform label Jul 22, 2019
This was referenced Jul 22, 2019
Closed
Merged
@russellb
Copy link
Member Author

related: #2038

This issue is kind of a duplicate, but we can leave them both open ...

cybertron added a commit to cybertron/installer that referenced this issue Jul 23, 2019
@cybertron
Pass baremetal infra images to MCO bootstrap
b59d814 
In order for the baremetal infra services to use the images from the
release, we need to look up the correct image during bootstrap and
pass that in to the MCO.

Part of the changes for openshift#2067
This was referenced Jul 24, 2019
Merged
Closed
cybertron added a commit to cybertron/installer that referenced this issue Jul 26, 2019
@cybertron
Pass baremetal infra images to MCO bootstrap
6158aeb 
In order for the baremetal infra services to use the images from the
release, we need to look up the correct image during bootstrap and
pass that in to the MCO.

The new image parameters were added to MCO in
openshift/machine-config-operator#795

Part of the changes for openshift#2067
@cybertron cybertron mentioned this issue Jul 26, 2019
Merged
@hardys hardys mentioned this issue Jul 26, 2019
Merged
hardys pushed a commit to hardys/installer that referenced this issue Jul 26, 2019
baremetal: Start coredns/keepalived after crio
6dab501 
The latest bootimage enables the crio-wipe service, which cannot run
successfully if we've started containers directly with podman prior
to the crio service coming up.

The final fix for this will be to move these services to the MCO
which is in progress via openshift#2067
but this implements a stopgap solution which is to ensure the podman
containers aren't started until crio is up.

Closes: openshift#2104
@stbenjam
Copy link
Member

stbenjam commented Jul 31, 2019 •
edited
Loading

@russellb Can you confirm if #2119 fixed this issue? Combined with openshift/machine-config-operator#1002, it looks like we're doing everything in MCO now. Is there something left to handle?

@russellb
Copy link
Member Author

yes, looks like this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cybertron cybertron

Labels
platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@russellb @stbenjam @cybertron