Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baremetal: Migrate Ironic services to upstream images #2090

Closed
hardys opened this issue Jul 25, 2019 · 6 comments · Fixed by #2234
Closed

baremetal: Migrate Ironic services to upstream images #2090

hardys opened this issue Jul 25, 2019 · 6 comments · Fixed by #2234
Labels
platform/baremetal IPI bare metal hosts platform

Comments

@hardys
Copy link
Contributor

hardys commented Jul 25, 2019

The integration proposed via #2079 currently depends on some upstream images, because those in the openshift org are still in-progress.

This issue is to track moving to the correct OCP builds of these containers, and also similar to #2067 we should look at options to move to a staticpod, and perhaps also the MCO instead of the current systemd/script approach.

Ideally I'd like to not block the initial experimental support on this, so I'm raising this as a separate issue to #2060 and we'll address these issues via follow-up PRs

@abhinavdahiya
Copy link
Contributor

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Jul 25, 2019
@stbenjam
Copy link
Member

stbenjam commented Aug 5, 2019

It looks like all the ironic and image downloading containers are in the releases now:

  ironic-image                                  sha256:43dce5dd426ae94ea28b4a074f55336256a05428fbdc631e4391160208b4769e
  ironic-inspector-image                        sha256:c4bd790f1928023425695330eb025098259e7533c78d12b15e992d0c3a9ff59e
  ironic-ipa-downloader                         sha256:29b7428d4a886e4ee7c41128a19d7a0112cd846994ac8c33f0e1c264b41441fa
  ironic-rhcos-downloader                       sha256:281af58fc909a6a45c0669264e6ab95e80365f7df2fc148c086ba83722ab96a7

How would we move it to the static pods? I think we want to ensure an ordering - right? Downloading of images needs to happen before Ironic starts, can that be controlled in MCO? Is this something we need to deal with later?

@dhellmann
Copy link
Contributor

Those image names are going to be changing shortly. See openshift/release#4623 and openshift/machine-api-operator#370

@hardys
Copy link
Contributor Author

hardys commented Aug 22, 2019

@stbenjam I raised #2251 to investigate how we migrate to staticpods, I'm unclear if MCO Is an option since we only want this to run on the boostrap VM?

I know @cybertron did the work to move the DNS services (which do have a slightly different configuration on the bootstrap VM) to MCO, perhaps he can provide some pointers before we dig into it.

@cybertron
Copy link
Member

Yeah, we have separate networking service configs for bootstrap, so it should be possible. You can see the change I made to do that in openshift/machine-config-operator@ec7ef01

Note in particular that bootstrap pod definitions go in manifests/. We also have some in templates/, but those are for the masters and workers.

As far as ordering, could you do the image download as an initContainer? We use one to generate our config before we start the service. Seems like that would serve your purposes too.

@stbenjam
Copy link
Member

#2251 sounds more elegant, but I don't think we can get that in this week, right? My understanding is we need to land #2234 before Friday to make 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/baremetal IPI bare metal hosts platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants