Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1718054: Do not log OAuth tokens in audit logs #500

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Bug 1718054: Do not log OAuth tokens in audit logs #500

merged 1 commit into from
Jun 18, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #499

/assign deads2k

@enj
Do not log OAuth tokens in audit logs
c623cf1 
Even the metadata level is not safe as metadata.name is the secret.

Signed-off-by: Monis Khan <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 7, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead

In response to this:

[release-4.1] Bug 1718052: Do not log OAuth tokens in audit logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2019
@enj
Copy link
Contributor

enj commented Jun 7, 2019

@deads2k please update the PR title to reference 1718054 instead.

@deads2k deads2k changed the title [release-4.1] Bug 1718052: Do not log OAuth tokens in audit logs Bug 1718052: Do not log OAuth tokens in audit logs Jun 7, 2019
@deads2k
Copy link
Contributor

deads2k commented Jun 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@deads2k
Copy link
Contributor

deads2k commented Jun 7, 2019

@deads2k please update the PR title to reference 1718054 instead.

You can't do this?

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@deads2k deads2k changed the title Bug 1718052: Do not log OAuth tokens in audit logs Bug 1718054: Do not log OAuth tokens in audit logs Jun 7, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 7, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1718054: Do not log OAuth tokens in audit logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekwaynecarr
Copy link
Member

master branch has soaked for 2 weeks.

/cherry-pick-approved

@derekwaynecarr
Copy link
Member

/cherry-pick-approve

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6b2886f into openshift:release-4.1 Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @enj @deads2k @derekwaynecarr @openshift-merge-robot