Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: cert-rotation: use new-style cert rotation controllers #1712

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

WIP: cert-rotation: use new-style cert rotation controllers #1712

wants to merge 8 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jul 9, 2024

… for generated certificates"

This reverts commit 5823d3d.

@vrutkovs
Bump library-go
c2239c1
@vrutkovs
certrotationcontroller: use NewCertRotationControllerMultipleTargets …
3ebe1cb 
…where possible
@vrutkovs
Remove RefreshOnlyWhenExpired
61bb030 
That makes cert-rotation controllers uniform to do proper leader election
@vrutkovs
Run cert-rotation controller as a sidecar in the operator too
b8212c7
@vrutkovs
cert-rotation controller: use shorter lease duration
5d6766f 
This uses shorter lease duration periods so that suspended/shutdown controller would not wait several minutes to grab the lease and start refreshing certificates sooner
@vrutkovs
Reapply "certrotationcontroller: set AutoRegenerateAfterOfflineExpiry…
bf730ea 
… for generated certificates"

This reverts commit 5823d3d.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs changed the title Bump library-go WIP: Bump library-go Jul 9, 2024
@vrutkovs vrutkovs changed the title WIP: Bump library-go WIP: cert-rotation: use new-style cert rotation controllers Jul 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@vrutkovs
Copy link
Member Author

vrutkovs commented Jul 9, 2024

/test e2e-aws-ovn e2e-gcp-operator e2e-aws-ovn-serial

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch 4 times, most recently from 0f0168b to 582f2ca Compare July 10, 2024 06:25
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn e2e-gcp-operator e2e-aws-ovn-serial

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch from 582f2ca to 31c7013 Compare July 10, 2024 07:53
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch from 31c7013 to 7fe65ce Compare July 10, 2024 09:50
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch from 7fe65ce to cf82383 Compare July 10, 2024 09:54
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch from cf82383 to 21a8a2f Compare July 10, 2024 15:27
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-new-rotations branch from 21a8a2f to 7bf3a32 Compare July 10, 2024 19:06
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn e2e-gcp-operator e2e-aws-ovn-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-bot @openshift-merge-robot