-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2513: Remove cloud-provider and cloud-config flags #1656
Conversation
@nrb: This pull request references OCPCLOUD-2513 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
A cluster was successfully created with this PR, combined with openshift/library-go#1692 and openshift/cluster-kube-controller-manager-operator#799. Leaving in draft til openshift/library-go#1692 merges and I can remove the |
/retest quay was returning 500s, which is unrelated to the changes. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1666 included the necessary changes. |
@nrb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Remove cloud-provider and cloud-config arguments from the Kube API server invocation. These flags are depecrated and will be an error to call later.
Note: to be grouped with openshift/library-go#1692