Bug 1752088: UPSTREAM: <carry>: openshift: Drop isDeleteAllowed func #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
enxebre
changed the title
|
@enxebre: This pull request references Bugzilla bug 1752088, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
bison
reviewed
Sep 17, 2019
| return true | ||
| } | ||
|
|
||
| if machine.Status.NodeRef.Name != r.nodeName { |
There was a problem hiding this comment.
Do we need the nodeName field at all now? If not, let's remove it.
isDeleteAllowed prevented a machine backing a node where the machine controller is running from being deleted. The controller is meant to be a simple CRUD and for single master scenarios upper level tooling should provide smarter logic
enxebre
force-pushed
the
drop-isDeleteAllowed
branch
from
66d18cd to
1c4b6df
Compare
openshift-ci-robot
added
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-merge-robot
merged commit 655e2d6
into
openshift:openshift-4.2-cluster-api-0.1.0
enxebre
added a commit
to enxebre/cluster-api-provider-aws-2
that referenced
this pull request
Sep 17, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-gcp-1
that referenced
this pull request
Sep 17, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-azure
that referenced
this pull request
Sep 17, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-openstack
that referenced
this pull request
Sep 17, 2019
openshift-merge-robot
added a commit
to openshift/cluster-api-provider-aws
that referenced
this pull request
Sep 17, 2019
Bug 1752088: UPSTREAM: <carry>: openshift: Revendor to bring openshift/cluster-api#72
openshift-merge-robot
added a commit
to openshift/cluster-api-provider-gcp
that referenced
this pull request
Sep 17, 2019
Bug 1752088: UPSTREAM: <carry>: openshift: Revendor to bring openshift/cluster-api#72
openshift-merge-robot
added a commit
to openshift/cluster-api-provider-openstack
that referenced
this pull request
Sep 17, 2019
Bug 1752088: UPSTREAM: <carry>: openshift: Revendor to bring openshift/cluster-api#72
openshift-merge-robot
pushed a commit
to openshift/cluster-api-provider-azure
that referenced
this pull request
Sep 17, 2019
enxebre
added a commit
to enxebre/cluster-api-provider-aws-2
that referenced
this pull request
Oct 4, 2019
…ster-api#72" This reverts commit f14d88b.
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isDeleteAllowed prevented a machine backing a node where the machine controller is running from being deleted. The controller is meant to be a simple CRUD and for single master scenarios upper level tooling should provide smarter logic.
Supersedes #49 so introducing annotation can be considered later on.