-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1752088: UPSTREAM: <carry>: openshift: Revendor to bring https://github.com/openshift/cluster-api/pull/72 #67
Conversation
@enxebre: This pull request references Bugzilla bug 1752088, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ping @tomassedovic @Fedosin |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow for passing the machine username in the providerConfig. This is mostly needed by the `clusterctl` command and we should probably find a better way to get the kubeconfig data. Until then, let's not hardcode the username in the implementation. Closes openshift#66
Allow for passing the machine username in the providerConfig. This is mostly needed by the `clusterctl` command and we should probably find a better way to get the kubeconfig data. Until then, let's not hardcode the username in the implementation. Closes openshift#66
Allow for passing the machine username in the providerConfig. This is mostly needed by the `clusterctl` command and we should probably find a better way to get the kubeconfig data. Until then, let's not hardcode the username in the implementation. Closes openshift#66
Revendor to bring openshift/cluster-api#72