Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1752088: UPSTREAM: <carry>: openshift: Revendor to bring https://github.com/openshift/cluster-api/pull/72 #67

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 17, 2019

Revendor to bring openshift/cluster-api#72

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 17, 2019
@openshift-ci-robot
Copy link

@enxebre: This pull request references Bugzilla bug 1752088, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1752088: UPSTREAM: : openshift: Revendor to bring openshift/cluster-api#72

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2019
@enxebre
Copy link
Member Author

enxebre commented Sep 17, 2019

ping @tomassedovic @Fedosin

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 15af0c0 into openshift:master Sep 17, 2019
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Mar 27, 2020
Allow for passing the machine username in the providerConfig. This is
mostly needed by the `clusterctl` command and we should probably find a
better way to get the kubeconfig data. Until then, let's not hardcode
the username in the implementation.

Closes openshift#66
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
Allow for passing the machine username in the providerConfig. This is
mostly needed by the `clusterctl` command and we should probably find a
better way to get the kubeconfig data. Until then, let's not hardcode
the username in the implementation.

Closes openshift#66
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Allow for passing the machine username in the providerConfig. This is
mostly needed by the `clusterctl` command and we should probably find a
better way to get the kubeconfig data. Until then, let's not hardcode
the username in the implementation.

Closes openshift#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants