Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused machine fields #34

Merged
merged 5 commits into from
Apr 29, 2019
Merged

Drop unused machine fields #34

merged 5 commits into from
Apr 29, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Apr 29, 2019 •
edited
Loading

drop unused machine fields:

  • machine.spec.versions
  • machine.spec.configsource -- we don't use dynamic kubelet config
  • machine.spec.providerSpec.machineClass -- we are not shipping the machine class resource at this time
  • machine.status.versions -- we are not setting this yet
  • machine.status.conditions -- we are not setting these node conditions up to machine objects yet

Follow ups:

  • Revendor cluster-api-provider-aws
  • Revendor installer
  • Update mao CRDs

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2019
@frobware frobware changed the title Drop fields Drop unused machine fields Apr 29, 2019
frobware
frobware reviewed Apr 29, 2019
View reviewed changes
Copy link

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting on https://github.com/openshift/cluster-api/pull/34/files/e0a3702b5f8dd60c8d8a114747d1957132079f95#r279309452

@frobware
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2019
@ingvagabund
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit d8958b5 into openshift:openshift-4.0-cluster-api-0.0.0-alpha.4 Apr 29, 2019
@enxebre enxebre mentioned this pull request Apr 29, 2019
Merged
enxebre added a commit to enxebre/cluster-api-actuator-pkg that referenced this pull request Apr 29, 2019
@enxebre
Accomodate machine specs for openshift/cluster-api#34
6b143d2
@enxebre enxebre mentioned this pull request Apr 29, 2019
Merged
@ingvagabund ingvagabund mentioned this pull request Apr 29, 2019
Merged
enxebre added a commit to enxebre/installer that referenced this pull request Apr 29, 2019
@enxebre
Revendor for cluster-api
aaf339a 
Revendor to accomodate openshift/cluster-api#34 for the machine renderered manifests so they pass CRD validation once they are updated
@enxebre enxebre mentioned this pull request Apr 29, 2019
Merged
enxebre added a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Apr 29, 2019
@enxebre
Revendor for cluster-api openshift/cluster-api#34
af864a8
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Apr 29, 2019
@enxebre
Revendor to accomodate the CRDs for openshift/cluster-api#34
3c17163
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Apr 29, 2019
@enxebre
Update CRDs for openshift/cluster-api#34
b302880
@enxebre enxebre mentioned this pull request Apr 29, 2019
Merged
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Apr 29, 2019
@enxebre
Revendor to accomodate the CRDs for openshift/cluster-api#34
a5705e0
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Apr 29, 2019
@enxebre
Update CRDs for openshift/cluster-api#34
3413167
enxebre added a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Apr 29, 2019
@enxebre
Accomodate providerConfigFromMachine to only use providerSpec.Value
ad204d3 
Accomodate providerConfigFromMachine to only use providerSpec.Value based on changes in openshift/cluster-api#34
@enxebre enxebre mentioned this pull request May 3, 2019
Merged
@alexander-demicev alexander-demicev mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@frobware frobware frobware left review comments

@bison bison Awaiting requested review from bison

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enxebre @frobware @ingvagabund @openshift-ci-robot @openshift-merge-robot