UPSTREAM: <carry>: openshift: build fixes due to new cluster-api vendor and addition of managed identity #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or and addition of managed identity
openshift-ci-robot
added
the
size/XXL
awesomenix
changed the title
frobware
approved these changes
May 2, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
enxebre
reviewed
May 3, 2019
| @@ -370,6 +366,8 @@ func TestNodeJoinSecondControlPlane(t *testing.T) { | |||
| t.Errorf("failed to create machine: %+v", err) | |||
| } | |||
|
|
|||
| t.Logf("%+v", fakeScope.Machine) | |||
|
thanks a lot! nit: instead of "build fixes due to new cluster-api vendor" which does not help for someone with no context we should point the openshift/cluster-api relevant PRs in the commit desc and mention what it does explicitly e.g "Adapt actuator to work without API fields dropped by openshift/cluster-api#35 and openshift/cluster-api#34" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: