-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-4966 Mapping /run/media directory to the next_step agent #1780
MGMT-4966 Mapping /run/media directory to the next_step agent #1780
Conversation
This PR is related to an agent PR: openshift/assisted-installer-agent#197 This PR aready merged openshift#1685 and reverted openshift#1691 after discovering that /run/media/iso directory does not exist for a minimal ISO so here we mounted the /run/media directory which exist in them both When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message. Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically. Since this error is common to all the steps, we add this verification to the agent. /run/media/iso is the ISO directory which mounted to the ISO device for a full-iso The disconnection event not reproduced for the minimal-iso
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaellevy101 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please do not review the agent PR because it's not aligned with the new design. |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR is related to an agent PR: openshift/assisted-installer-agent#197
This PR aready merged #1685 and reverted #1691 after discovering that /run/media/iso directory does not exist for a minimal ISO
so here we mounted the /run/media directory which exist in them both
When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message.
Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically.
Since this error is common to all the steps, we add this verification to the agent.
/run/media/iso is the ISO directory which mounted to the ISO device for a full-iso
The disconnection event not reproduced for the minimal-iso