MGMT-4966 Display a better message when media disconnection failure o… #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaellevy101 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc @omertuc |
|
/hold until the assisted service PR merges |
openshift-ci
bot
added
the
do-not-merge/hold
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
omertuc
reviewed
May 9, 2021
michaellevy101
force-pushed
the
MGMT-4966
branch
2 times, most recently
from
b71cf01 to
ee6f469
Compare
omertuc
reviewed
May 9, 2021
michaellevy101
pushed a commit
to michaellevy101/assisted-service
that referenced
this pull request
May 20, 2021
This PR is related to an agent PR: openshift/assisted-installer-agent#197 This PR aready merged openshift#1685 and reverted openshift#1691 after discovering that /run/media/iso directory does not exist for a minimal ISO so here we mounted the /run/media directory which exist in them both When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message. Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically. Since this error is common to all the steps, we add this verification to the agent. /run/media/iso is the ISO directory which mounted to the ISO device for a full-iso The disconnection event not reproduced for the minimal-iso
openshift-merge-robot
pushed a commit
to openshift/assisted-service
that referenced
this pull request
May 21, 2021
This PR is related to an agent PR: openshift/assisted-installer-agent#197 This PR aready merged #1685 and reverted #1691 after discovering that /run/media/iso directory does not exist for a minimal ISO so here we mounted the /run/media directory which exist in them both When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message. Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically. Since this error is common to all the steps, we add this verification to the agent. /run/media/iso is the ISO directory which mounted to the ISO device for a full-iso The disconnection event not reproduced for the minimal-iso
michaellevy101
force-pushed
the
MGMT-4966
branch
2 times, most recently
from
ded14f7 to
05b1f4b
Compare
|
/hold until testing it |
avishayt
reviewed
May 24, 2021
avishayt
reviewed
May 24, 2021
michaellevy101
force-pushed
the
MGMT-4966
branch
5 times, most recently
from
4a454c9 to
9de2af8
Compare
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
omertuc
reviewed
May 31, 2021
…ccurs When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message. Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically. Since this error is common to all the steps, we add this verification to the agent The indication to error is reading from the file failed
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ccurs
When a media disconnection error occurred the system became unstable and the step execution might be stuck on IO errors or failed with an unfriendly message.
Media disconnection occurred when a network drive (mostly PXE) has any errors (Network issue) and the controller disconnects it automatically.
Since this error is common to all the steps, we add this verification to the agent
The indication to error is reading from the file failed