-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-6455 KubeAPI Controllers Debuggability: Add Logger Fields #1741
MGMT-6455 KubeAPI Controllers Debuggability: Add Logger Fields #1741
Conversation
c53ef3d
to
4af778f
Compare
/test subsystem-kubeapi-aws |
/test subsystem-aws |
Could we change the notation to something else than spaces?
Maybe |
Usually we call the fields with a snakecase for example |
89b3cc8
to
af7b00f
Compare
af7b00f
to
ef9cfee
Compare
1455cbc
to
229d16b
Compare
ffbe4b4
to
019626f
Compare
/unhold |
/assign @djzager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be nice for us to all use the same logger. I'll save the 👍 for someone else but this looks good to me.
/lgtm |
This change adds logger fields to controllers to specify the resource name and namespace that is being reconciled. Additionally, in a case that context does not have a request-id, we'll generate one to track it down both in controllers and the backend. Lastly, I added a log indicating that a reconcile iteration has ended.
019626f
to
727f769
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, nmagnezi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-metal-assisted-operator-ztp |
/retest Please review the full test history for this PR and help us cut down flakes. |
This change adds logger fields to controllers to specify the
resource name and namespace that is being reconciled.
Additionally, in a case that context does not have a request-id,
we'll generate one to track it down both in controllers and the backend.
Lastly, I added a log indicating that a reconcile iteration has ended.